4 replies to this topic

[Eedis]

So I was having some issues with a script while using the Sort command. tidbit finally solved the issue with me after some tinkering on IRC.
When the contents of Genre.txt are:Action
Cartoon
Comedy
Crime
Documentary
Drama
Family
Fantasy
Film Noir
Foreign
Hacker
Horror
Kung Fu
Puzzle
Romantic
Sci Fi
Sport
Thriller
Trilogy
Twistthis script will remove the trailing 't' in the word Twist.

FileRead, GenreCont, %a_desktop%\Genres.txt
CurGenre=Jesus
GenreCont.="`n" CurGenre

Msgbox, % GenreCont
Sort, GenreCont
Msgbox, % GenreCont

But when adding this extra line to remove all of the instances of `r, it works perfectly fine.

FileRead, GenreCont, %a_desktop%\Genres.txt
CurGenre=Jesus
GenreCont.="`n" CurGenre

[color=#BF0000]StringReplace, GenreCont, GenreCont, `r,, ALL[/color]

Msgbox, % GenreCont
Sort, GenreCont
Msgbox, % GenreCont

I'm not sure if this would constitute a bug or not, so remove if you must. If it's not, an explanation at why this little gremlin exists would be grand.

Thanks!

[tidbit]

Note:
This happened on AHKL v1.1.08.01 unicode x64.
OS: Win7 64bit

[just me]

Behavior confirmed for AHK 1.1.07.01 U32 on WinXP.

Edit: Also confirmed for AHK 1.0.48.05 (latest stable version) on WinXP.

Just another "workaround":

GenreCont .= "[color=#BF0000]`r[/color]`n" . CurGenre

[TLM]

ah I using just me's 'workaround format' pretty much all the time that's why I couldn't reproduce it.
Yep its happening here now too 1.1.08.01 + 1.0.48.05

[Lexikos]

If the first item ends with `r, all items must end with `r. Aside from the truncation you've noticed, detection of duplicates (option U) relies on the delimiters being consistent. If the input is inconsistent, the output will be inconsistent. Make sense?

I suppose the options are:

• Leave everything as is, and require that the delimiters are consistent.
• Fix the truncation, but not the inconsistency with detection of duplicates.
• Fix the truncation and improve consistency by unconditionally treating `r as part of the item, rather than the delimiter.
• Treat `r as part of the delimiter, discarding it and arbitrarily deciding whether the output should contain `n or `r`n between each and every item.

Except with the last option, the recommendation would be to always use consistent delimiters. In that case, I'm inclined to assign a very low priority to this issue.

This demonstrates the inconsistency:

v=
(Join
one`r`n
one`r`n
two`n
two
)
Sort v, U
MsgBox % v  ; one, two, two