AutoHotkey Community

haichen,
Good guess, but removing the "]" from the "*.ini]" did not resolve the problem, I still get the same error.

toralf,
Don't you know that as soon as the doc it written it becomes obsolete? The code reads "ini_MoveKey(ByRef var, from, to, key, copy = false) {"

_________________
-------------
Scott Mattes

My small, and slowly growing, collection of scripts.

Hi scottmattes, I think I found the problem:


Maybe this was what haichen was referring to

_________________
GitHub • Scripts • IronAHK • Contact by email not private message.

Titan,
Right you are! I saw the ] and focused on that.

Is it just me, or does the error reported seem 'wrong'? Like, I guess that I am wondering why ahk didn't raise an error before getting to the ini.ahk code.

O well, thank you for finding my error for me.

_________________
-------------
Scott Mattes

My small, and slowly growing, collection of scripts.

I often make such mistakes when I work with Includes. Sorry of being a bit short.

Ran into a problem with _ini_(un)escape. One of my values contained \r, which resulted in it being converted to a carriage return. A simple fix would be to modify the escaped version of "`r" and "`n" to something like "{INI_CARRIAGE_RETURN}" and "{INI_NEWLINE}".

It also looks like ini_Save isn't escaping properly.

I can't get ini_Save to work, and I've found some issues (some of which have already been stated).

Line 442:


Should be:


Line 451:


%s% is a blank variable at the start of the loop, so you're removing all newlines of the section list on loop pass 1 and doing nothing for the other passes, as far as I can tell. I think this line should be moved up above 451:


Finally, as another user stated, %file% is not defined when you use it at the end of the function. %src% used to contain the filename, but was overwritten at the beginning with the file contents. Before it's overwritten, you need to add:


Testing to see if additional changes are needed to get it working...

Update: Definitely still not working. The Save function looks like a mess! I hope the other functions are sound, as I hope to be able to use this library when I figure out the save function.

_________________
Ben

My Trac projects
My Wiki
[Broken] - My music

Is that RegEx really so slow compare to string functions ?

In general, no. Compared to string functions, generally yes. Kind of a speed vs. convenience trade-off.

_________________
Ben

My Trac projects
My Wiki
[Broken] - My music

I also found that the ini_Save functionality is not working.

When someone (maybe even me) fixes this problem, please post the code. The ini library is really fast and I would like to be able to write to file.

Thanks

I don't know exactly how the speed compares, but if you can't figure this out,
you might want to try my IniFile class also in these forums which I created because
this library had some unresolved issues. Initial reports indicate it's pretty fast and
all functions work.

_________________
Ben

My Trac projects
My Wiki
[Broken] - My music

The ini_Save works fine. You will notice that at the bottom Titan uses
%file% . This is empty. So you just need to create a copy of the file uptop before any changes happen. Viola you got a working program.



And it is much faster than other routines purely because it stores the ini file in memory. So unless you're ini file is really small it wont be worth using it.

Ini_save doesn't work for me in Vista 64-bit, even when populating the %file% variable properly in the function. You'll notice in my posts above there are several other code errors I found, but even when I fixed them it still did not work for me.

My IniFile class is object-oriented, and also stores the Ini file in memory for ultra-fast access, FYI. It parses the whole file into sections and fields (separated by key, value, and comment) when opening it, so it doesn't have to parse the file when you actually run your operations on it. And the save function works, and I don't believe there are errors or omissions in the current code.

So if you can't get this to work, as I couldn't, and because this doesn't seem to be supported anymore (or currently, at least), feel free to give my library a try here.

I even created function aliases in my library so that you can use almost the exact same syntax you use with the Ini_ library, but with IniFile_ before it.

You can also use both at the same time, because I changed the name to IniFile for mine. So feel free to compare and share your results. I've tried to cater to fans of this library, since I'm a fan of this library.

_________________
Ben

My Trac projects
My Wiki
[Broken] - My music

I still dont get it why it works like this



while it doesn't like this (even though I guess that's the intended most common usage):



although the last lines in the invoked function look exactly like those in the working example



src_file is = 1, %file% contains exactly the same value as per the working example (that is a correctly placed existing ini file, it aint empty Boontjie...).
testing ErrorLevel (via OutputDebugger) both after the attempted deletion and file append show a failure on both commands

Unfortunately this library doesnt work.
Or at least I cant make it working
Aside the objections above:

you cant have a key containing C:\remainder or C:\nicholas as value because \r and \n will be escaped/unescaped with funny results.

I found also:

if my code tries to write an empty string in a key, the key and values of the immedialy subsequent one will be deleted and lost

If a section gets vacated of keys the entire section is deleted...

I gave up and switched to the old fashioned ahk directives
It was nice (and fast, veeery fas!!) to handle INI in memory with no disk access.
I doubt that this should still be included in the Wiki catalogue.

_________________
Intel Centrino @ 2.8GHz
4 GB RAM
WIN XP SP3

Found the bug in ini_Write function
Line 95 and 97 (contained in ini_Write) are:

if one passes an empty string to write in the key that "+1" at the end of the line 95 gets the following StringGetPos call to set the string trimming right at the end of the following key
so a section like this
[SOMESECTION]
Key1=somevalues1
key2=somevalues2

after a manipulation like

where newVal is an empty string (I want to keep the key but with no value set) becomes:
[SOMESECTION]
Key1=

WHAT?!! IVE LOST Key2 WHICH WASNT EVEN MEANT TO BE TOUCHED!!
yep.
Ive changed the above lines into

and now it looks like it's working fine, at least for my usage.
I've also made (see bmcclure and Coryf88 posts above) these other changes in the Titan's original code:

again it works for my own usage wich is limited to load, read, write, delete and save. dunno abt the rest.

_________________
Intel Centrino @ 2.8GHz
4 GB RAM
WIN XP SP3