View topic - image searches always yes • AutoHotkey Community

View unanswered posts | View active topics

Board index » AutoHotkey » Support

All times are UTC [ DST ]

image searches always yes

Page 1 of 2

[ 30 posts ]

Go to page 1, 2 Next

Print view | E-mail friend

Previous topic | Next topic

Author

Message

Puttah

Post subject: image searches always yes

Posted: November 8th, 2009, 4:45 am

Joined: November 7th, 2009, 12:01 pm
Posts: 60

I've tried imagesearching for a small (about 20x20) box that has a mix of two colours. But while testing it out, I always get the answer yes in this script:

Code:

^H::
Imagesearch, X,Y, 1003,52,1061,111, C:\Users\My Documents\Pictures\test.png
if errorlevel,
   msgbox, no
else,
   msgbox, yes
return

I don't understand why. Even when I have a completely white background (which the image has shades of grey and black) it still sends me the answer yes...

Top

Ace Coder

Post subject:

Posted: November 8th, 2009, 4:56 am

Joined: October 26th, 2009, 6:29 am
Posts: 362

Your allowing for 111 offset. Change it to about 20.

Top

Puttah

Post subject:

Posted: November 8th, 2009, 5:09 am

Joined: November 7th, 2009, 12:01 pm
Posts: 60

Uhh sorry, could you please repeat that in layman terms?

Top

Ace Coder

Post subject: Re: image searches always yes

Posted: November 8th, 2009, 5:13 am

Joined: October 26th, 2009, 6:29 am
Posts: 362

Puttah wrote:

Code:

^H::
Imagesearch, X,Y, 1003,52,1061,111, C:\Users\MyDocuments\Pictures\test.png
if errorlevel,
   msgbox, no
else,
   msgbox, yes
return

Try changing the number 111 to a lower number.
The number tells the script how far off the picture can be, on the scale of 0 (perfect match) to 255 (everything matches).

Top

BF2 Player

Post subject:

Posted: November 8th, 2009, 5:14 am

Joined: March 27th, 2009, 10:48 pm
Posts: 71

Code:

^H::
Imagesearch, X,Y, 1003,52,1061,111, C:\Users\My Documents\Pictures\test.png
if errorlevel,
   msgbox, no
else,
   msgbox, yes
return

It should be this:

Code:

^H::
Imagesearch, X,Y, 1003,52,1061,20, C:\Users\My Documents\Pictures\test.png
if errorlevel,
   msgbox, no
else,
   msgbox, yes
return

Either 20 or lower is good

Top

Ace Coder

Post subject:

Posted: November 8th, 2009, 5:14 am

Joined: October 26th, 2009, 6:29 am
Posts: 362

Ninjad!!

Top

Puttah

Post subject:

Posted: November 8th, 2009, 5:17 am

Joined: November 7th, 2009, 12:01 pm
Posts: 60

Oh haha those are meant to be the coordinates, right?

I mean, the top left corner should be at 1003,52
and the bottom right corner should be at 1061,111

And yeah I would only put the offset to about 10 max. So how could I write this line in order to get 10 offset and still have my imagesearch box coordinates defined as so?

Top

Ace Coder

Post subject:

Posted: November 8th, 2009, 5:27 am

Joined: October 26th, 2009, 6:29 am
Posts: 362

Omg....
Im a noob!!!!! :evil:

Sorry I barely glanced at the code.
Your right, those are just coordinates.
Anyways...
I don't normally use ErrorLevel for ImageSearch... I would do this...

Code:

^H:: 
X=
Y=
Imagesearch, X,Y, 1003,52,1061,111,15, C:\Users\My Documents\Pictures\test.png ;The 15 is the offset

If X= ;If X is empty after the search
{
   msgbox, no 
}

If X<> ;If X isn't empty after the search
{
   msgbox, yes 
}
return

Top

Puttah

Post subject:

Posted: November 8th, 2009, 5:38 am

Joined: November 7th, 2009, 12:01 pm
Posts: 60

Ahh it's ok

Well, I tested that one out and it sure has made a difference. Now I always get "no" as a result even when the picture is there. I even bumped up the offset to a massive 150, and still get the same result - so maybe the script has a typo or something in it? (is that what a bug in computer language means?)

And I would still prefer to use errorlevel, since I've got quite a few imagesearches in one script.

I used to write scripts, but after a year's break, everything just flies out the window and you're left with nothing but blurry and fuzzy memories.

Top

OceanMachine

Post subject:

Posted: November 8th, 2009, 5:48 am

Joined: October 15th, 2007, 3:10 pm
Posts: 790
Location: England

@Ace Coder & BF2: That's not how you put the variation in!

Try this:

Code:

^H::
X := ""
Y := ""
Imagesearch, X, Y, 1003, 52, 1061, 111, *15 C:\Users\My Documents\Pictures\test.png ;The 15 is the variation
If ( ErrorLevel = 0 )
  MsgBox, Found the Image!!
Else If ( ErrorLevel = 1 )
  MsgBox, Image not found
Else
  MsgBox, ErrorLevel: %ErrorLevel% (2 indicates a problem of some kind)

Last edited by OceanMachine on November 8th, 2009, 5:54 am, edited 4 times in total.

Top

Leef_me

Post subject:

Posted: November 8th, 2009, 5:49 am

Joined: April 8th, 2009, 7:49 pm
Posts: 6068
Location: San Diego, California

Silly noobies :wink:

It's NOT is a problem with the ImageSearch command

Code:

errorlevel=0

if errorlevel, ; <-------- FAILS WHEN YOU USE THE COMMA!
   msgbox, no 
else, 
   msgbox, yes 
;return


errorlevel=1

if errorlevel, ; <-------- FAILS WHEN YOU USE THE COMMA!
   msgbox, no 
else, 
   msgbox, yes 
;return



errorlevel=0

if errorlevel ; <-------- WORKS WITHOUT THE COMMA!
   msgbox, no 
else, 
   msgbox, yes 
;return


errorlevel=1

if errorlevel ; <-------- WORKS WITHOUT THE COMMA!
   msgbox, no 
else, 
   msgbox, yes 
;return

Top

Ace Coder

Post subject:

Posted: November 8th, 2009, 5:53 am

Joined: October 26th, 2009, 6:29 am
Posts: 362

I hate my life...
Lol
A wise man once said...

Quote:

Ace Coder your a NOOB

Top

Puttah

Post subject:

Posted: November 8th, 2009, 5:54 am

Joined: November 7th, 2009, 12:01 pm
Posts: 60

LOL Leef_me thanks for the help. OceanMachine you've answered my next question since I'm sure I would still be at a loss without that little asteriks

All these tiny bugs, making such a big difference in the output... how silly!

I'll see if this new found knowledge gets me somewhere. Be back in a sec!

Top

Puttah

Post subject:

Posted: November 8th, 2009, 6:03 am

Joined: November 7th, 2009, 12:01 pm
Posts: 60

Has "ace" lost all meaning now-a-days? haha jk, it's cool, looking on the bright side I'm even more noob

Ok this is the code I have now:

Code:

^H:: 
Imagesearch, X,Y, 1003,52,1061,111, *10, C:\Users\My Documents\Pictures\test.png

If errorlevel
   msgbox, no
else,
   msgbox, yes
return

Now it always says no. I even bumped up the offset to 255 to be sure, and yes, my suspicions were settled. Something is still wrong with the coding since I still get the msgbox no.

Top

Ace Coder

Post subject:

Posted: November 8th, 2009, 6:12 am

Joined: October 26th, 2009, 6:29 am
Posts: 362

Here I go again... :oops:

Code:

^H::
Imagesearch, X,Y, 1003,52,1061,111, *10, C:\Users\My Documents\Pictures\test.png

If ErrorLevel<>0
{
   MsgBox, No Ace Coder is still a noob!
}

If ErrorLevel=0
{
   MsgBox, YES!!! ACE DID SOMETHING RIGHT!!
}
Return

Top

Page 1 of 2

[ 30 posts ]

Go to page 1, 2 Next

Board index » AutoHotkey » Support

All times are UTC [ DST ]

Who is online

Users browsing this forum: Bing [Bot], Google [Bot], Google Feedfetcher, Leef_me, Pulover, rbrtryn, XstatyK, Yahoo [Bot] and 31 guests

You can post new topics in this forum
You can reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum