Thanks. I've applied the patch and updated the downloads.
On a related note, I think we should replace (or supplement) the numeric flags with a more intuitive options string. I don't like having to refer to the documentation every time I want to call FileOpen. Perhaps something like this:
Code:
;First character indicates access mode
r read
w write
a append
u update (read/write)
;Subsequent characters are optional flags
r SHARE_READ
w SHARE_WRITE
d SHARE_DELETE
`n translate between `r`n and `n
`r replace standalone `r with `n when reading
;Example
f := FileOpen(fn, "ar`n") ; append and share read access
On another note, the methods used by some commands were implicitly (fopen) or explicitly (CreateFile) "sharing" the file. Some commands in AHKL/U were changed to use the TextStream class, so lock the file now - this might be problematic. The script below demonstrates these issues (keep in mind that in the real-world, the file could be read/written by some other application while the script is writing/reading it):
Code:
Loop, Read, %A_ScriptFullPath%
{ FileRead, s, %A_ScriptFullPath%
break
}MsgBox % ErrorLevel
Loop, Read, %A_ScriptFullPath%
{ FileAppend, `n`;testing, %A_ScriptFullPath%
break
}MsgBox % ErrorLevel
Standard AHK: both work.
Current builds: both fail.
Previous builds: FileRead works.
FileRead has the following comment:
Code:
// It seems more flexible to allow other processes to read and write the file while we're reading it.
// For example, this allows the file to be appended to during the read operation, which could be
// desirable, especially it's a very large log file that would take a long time to read.
It'll probably be easily fixed, when I get around to it. It'll be slightly less work now that the TextStream SHARE_* flags are in place.
Login
Register
FAQ
Search
...
