AutoHotkey Community

Hi

Perhaps someone can help.

I've got a loop that changes the names
of a directory's files, prepending the
digit 2 to the current names.


What's happening is that the first (alphabetically)
file in the directory is being hit twice by this loop.

Example: A directory initially contains these
three files:

0012.jpg
0013.jpg
0014.jpg

After passing thru the loop, it contains these three files:

20013.jpg
20014.jpg
220012.jpg

I put some debugging code into the loop, like this:


For the preceding example, the debugging output
looks like this:

index is 1 -- filename is 0012.jpg
index is 2 -- filename is 0013.jpg
index is 3 -- filename is 0014.jpg
index is 4 -- filename is 20012.jpg

Note that, although there are just 3 files,
the body of the loop executes four times;
thus the doubled 2-ing of the first file.

Have I bumped into an AHK file loop bug ?
Or is something else going on that my AHK-newbie
mind has not grokked correctly ?

tia

-- stan

I can't reproduce the problem. It is working on my machine if the code is in the same dir as the files.
I use AHK 1.0.40.06 on WinXP Pro SP2

Your code could be shorter:

If you want to have the code in a different dir:

_________________
Ciao
toralf

Although I can reproduce this, I think it's normal behavior due to a quirk in the Windows API. Apparently, MoveFile() can cause FindNextFile() to find the same file twice, once with its old name and again with its new name.

I don't see a way to easily fix this in the program, so I'd suggest a work-around such as the following, which builds a list of files and then parses it line by line afterward:

There's another advantage to chris' code: The order in which Loop reads the files is not neccessesary the one you are seeing or expecting. It may happen that you see File1, File2, File3 ... but Loop is reading File3, File1, File2, ...
This happens with FAT partitions under Win 98 sometimes. If you want to be sure that the files are read in ascending order use a Sort before:

_________________
Peter

Wisenheiming for beginners: KaPeGe (German only, sorry)

Hi Toralf

Interesting that the problem did not show up
on your system.

RE the shorter code: that was my original
code, but I two-lined it just in case
there was some sort of filename change
timing problem related to having
%A_LoopFileName% twice in the renaming line.

-- stan

Hi Chris

Thanks for the workaround code.

I'd assumed that the AHK code was doing what
the workaround does -- build a file list -- when
it hit the



statement.

-- stan

Hi Peter

Thanks for the sort variant.

-- stan