I'm sorry. I was basing my judgement on the 3.1 code I suggested. I looked at your code again:
Code:
Anchor(ctrl, a, draw = false) { ; v3.1 by Titan
static win, pos
pre = `n%A_Gui%:
If !InStr(win, pre)
win = %win%%pre%%A_GuiWidth%,%A_GuiHeight%
StringTrimLeft, wy, win, InStr(win, pre) + 2
StringLeft, wx, wy, InStr(wy, ",") - 1
StringRight, wy, wy, InStr(wy, ",") - 1
This will not work if in the string win more then one window is stored and the window that calls Anchor is not the last in the string! Since StringRight will then put a lot of garbage in wy.
Code:
If !InStr(pos, pre . ctrl) {
GuiControlGet, p, Pos, %ctrl%
pos = %pos%%pre%%ctrl%,%pX%,%pW%,%pY%,%pH%,
}
StringTrimLeft, p, pos, InStr(pos, pre . ctrl) + StrLen(ctrl) + 1
c = xwyh
Loop, Parse, c
If InStr(a, A_LoopField) {
StringGetPos, e, p, `,, L%A_Index%
StringTrimLeft, e, p, e + 1
StringLeft, e, e, InStr(e, ",") - 1
If A_Index < 3
e += A_GuiWidth - wx
Else e += A_GuiHeight - wy
The math with wx and wy is done every time Anchor is called, which can be very often. While in my code the wx and wy is substracted from the values only once. Which reduces the number of math actions.
Code:
m = %m%%A_LoopField%%e%
}
If draw
d = Draw
GuiControl, Move%d%, %ctrl%, %m%
}
You say, that my code uses extra calculations. I doubt that.
1) It is less math, if you cound the number of times simple math is performed. I'm counting "e += A_GuiWidth - wx" as two math operations.
2) My code uses an extra parse loop, but your code uses much more string manipulation. It would need a test to see which is faster. And BTW: The parse loop can be avoided and replaced with your code, but then a comma has to follow the pH in the pos string.
3) One benefit of my code is that the original window size doesn't have to be fetched each time Anchor is called, it is already in the pos of the control. Which in total saves 3 string manipulations (which might be buggy as mentioned above) each time Anchor is called (but adding 4 simple math operations for each control during first call). I guess the math math in the beginning is shorter in time then doing the string maipulation each time. But I might be wrong since all these are very simple operations which might be done by the OS in no time.
Sorry, for being stuborn. Discard my comments if they offend you.
A compromize would be:
Code:
Anchor(ctrl, a, draw = false) { ; v3.3 by Titan
static pos
If !InStr(pos, "|" . A_Gui . "_§$§_" . ctrl . ":") {
GuiControlGet, p, Pos, %ctrl%
pX -= %A_GuiWidth%
pW -= %A_GuiWidth%
pY -= %A_GuiHeight%
pH -= %A_GuiHeight%
pos = %pos%|%A_Gui%_§$§_%ctrl%:%pX%,%pW%,%pY%,%pH%,
}
StringTrimLeft, CtrlSize, pos, InStr(pos, "|" . A_Gui . "_§$§_" . ctrl) + StrLen("|" . A_Gui . "_§$§_" . ctrl) + 1
StringSplit, CtrlSize, CtrlSize, `,
c = xwyh
Loop, Parse, c
If InStr(a, A_LoopField) {
e := CtrlSize%A_Index%
If A_Index < 3
e += %A_GuiWidth%
Else
e += %A_GuiHeight%
m = %m% %A_LoopField%%e%
}
If draw
d = Draw
GuiControl, Move%d%, %ctrl%, %m%
}
*not tested*
Login
Register
FAQ
Search
