AutoHotkey Community

I went ahead and compiled editor.ahk... But now I'm not sure what I downloaded because the editor title says it's beta5.

2 Kerry
I may do that

2Nerd610again
Click right on tray icon, go to Setup->Appearance see bellow option "show editor at the bottom of the menu" and just replace Editor.exe with Editor.ahk

Yeah, Editor is beta5 because it is not changed from then... they can be used separately (Editor can be used without Favmenu).

The changes were made in Favmenu script, hence beta7

_________________

Makes total sense to me! Why didn't I just know that?

Hmm I keep getting an error when I try to run it. (not using TC though)

Error: ""is not a valid key name. The current thread will exit.
Line #
---> 849: Hotkey,%FavMenu_Options_OnOffKey%,FavMenu_OnOffHotKey,On

_________________
"I thought what I'd do was I'd pretend I was one of those deaf-mutes" ~ Laughing Man - GITS:SAC

2Laughing Man
Try deleting the config.ini and starting again (if you have one). If that fails, try to set OnOffKey value under Config.ini section [TCFavMenu] to something AHK meaningful (like !w.

I will chek it out as soon as I can.

_________________

Some trivial error.
Please redownload fixed version (I included compiled exes this time)

_________________

nice work, very handy indeed

Hmm for some reason it thinks I have TC cause it doesn't auto revert to windows explorer. Oh well I can just manually put the paths in. But what do I put in for the second field?

_________________
"I thought what I'd do was I'd pretend I was one of those deaf-mutes" ~ Laughing Man - GITS:SAC

Thank you.

2Laughing Man
You are very unlucky person lm That scenario is very impossible if you don't have TC, so you must be having it somewhere... or at least its registry settings.

Favmenu uses TCs wincmd.ini if it detects it. If it doesn't it will create sample menu for you (this faild for you since TC is detected).

To set it up manuely you do this:
In File Manager field enter : %WINDIR%\Explorer.exe
In Menu definition field enter: menu.ini

This is the sample menu. Paste this in a file named menu.ini and put it in the scripts directory.
I will add this as an option to the setup for eventual future scenarios (button to create sample menu)

Contest of menu.ini
[deleted; no-point now]

_________________

2Laughing Man
I did a small update for you.
I added option to create sample menu in Setup->Configuration dialog.
You don't have to do above procedure if you use this new version.

Check out on screenshot.

_________________

Thanks, I think the reason why it thought I had TC was I tried it once before but I uninstalled it.

_________________
"I thought what I'd do was I'd pretend I was one of those deaf-mutes" ~ Laughing Man - GITS:SAC

Yes, TC's settings were left in Registry upon uninstall.

I hope you wont have any more problems.

_________________

Memory story:

majestic @ Totalcmd.net
7MB memory usage?
Gigantic for such app

majkinetor @ Totalcmd.net
It doesn't use more then 3.5MB here.

majkinetor @ Totalcmd.net
OK, majestic you were right
It uses about 7MB of memory until it is Reloaded (from the tray menu). After that it drops to 2.5-3.5MB, so it is good advice to reload it after starting it. I might add this programaticaly.

This is some Windows unknown behavior. Reloading will execute another instance of AHK and close the prvious one, just like you open another FavMenu and closed previous after that. Why does that cuts the memory to half you will have to ask MS support

Also, you have to consider that this is a script (exe version is compiled AHK script). THerefore, it can not have the same minimal performance like it would be in C language. AHK by my knowledge outperformed all other scripting languages, so I guess it can not be better then this.


majkinetor @ AHK
I noticed that when you run any script for the first time, it eats much more memory then after you Reload it via internal command.

I tried on several different scripts and behavior is the same: Used memory is cut to half.

This is very strange behavior since Reload will spawn another AHK process and close itself so I don't know how that differs from cold start


Chris @ AHK
It could be that Reload results in less memory shown because the second instance shares memory (system resources) with the first instance.

If you're using Task Manager to gather these memory statisitcs, I don't think its "Mem Usage" column is an accurate reflection of how much memory a process has actually consumed. For details, see http://www.autohotkey.com/forum/viewtop ... 4247#24247

I am using TaskInfo & PRocess Explorer. Both report the same.

majkinetor @ AHK
Must be some weird Windows behavior.
This is info from running my FavMenu script (used as merging example). This script is big but it does nothing on startup except checking for few config enteries in ini file. Then it waits for the hotkey to do the work. I just launch (without hotkey call) and then reloaded. This is what I got:
Code:



Chris @ AHK

I checked the code and there isn't very much different between reload-mode and normal mode.

Rather than using "Working Set", perhaps it would be more accurate to use "VM Size" as shown by Task Manager.

majkinetor @ Totalcmd.net
After longer analysies of memory problem this is to take as a final note about it:

It is determinted by several other excellent programmers and me, that even the smallest windows application consume about 5MB of memory. We did examples in Watcom compiler (the litest of C compilers) creating 5KB exe files that do nothing. TaskManager reported 5MB MEM usage. It appears to be some internal memory alocation to handle security attributes, users rights or whatsoever, in any case, memory reported is not accurate. Favmenu itself uses about 30KB memory internaly and AutoHotKey scripting language according to my talk with the author eats memory far far from 5MB.

So, it appears to be false alarm...

You can ofcourse see processes in TaskManager that eat as low as 0.5MB RAM, but those are services or system drivers witch have entirely different SDK then normal windows application.
Windows Explorer itself is eating 25MB RAM here without any addons, witch is "Gigantic" for such app

_________________

I think that the Memory usage problem may be because of the dull INI Reads and frequent Create/Destroy Menu functions.
majkinetor, I very like your script, I also use TC about 10 years, good work! But, I have almost 200 items in the Menu, and the script works very slowly. A little suggestion to improve the script. Instead of dully calling FavMenu_CreateFullMenu(), FavMenu_Destroy(), Loop(IniRead()), compare wincmd.ini File Modification Date.

Currently I'm totally disabled recursive Menu Recreation. If it's necessary I simply reload the script manually. Btw, I didn't do that yet, because I not tend to change HotDirectoryList often. That's what I've added:
In result, menu displayed instantly, without the annoying 1-sec delay. Keep up the great work, and I hop you will consider my notices.


The script have a lot of ways to be improved. First, it could automatically resize the File Dialog Boxes, as similarly do File-Ex, XFilesDialog, FileBox Extender and almost any File Dialog manager. Apart from Standard File Dialog Boxes, other dialogs could be also automatically resized, like "Browse For Folder", Internet Explorer's "Add To Favorites", "Organize Favorites" dialogs. Dialogs Size, View Mode (Icon/Details) could be saved per-application. Apart from TotalCommanders favorites, a per-application managed Favorites list could be managed. Again, instead of constantly Recreating/Destroying the Menus, and Reading Configs, Menus should be added/removed individually with Menu Add/Delete commands.

2 Stevep
Steve, this script is ment for favorites and you generaly don't keep 200 hundreed items there but 10, 15, 30 at most... or it is not favorites at all

The menu was not refreshing every time until sombody asked for that.
I may add smarter refreshing in the future but it appeared that nobody except you now wanted that.

The memory problem has NOTHING to do with that, since memory consumation is big before you call the Favmenu for the first time at witch moment it created about 15 variables and rested peacefully.

Even for 200 items you have you will get max 200KB consumption but it will be slow on display since it has to create them all again as they are destoryed once you hide the menu.

I can not compare with wincmd.ini File Modification Date since this file is changed constantly. The only thing I can do is check [DirMenu] section for changes eatch time.... or I can add as an option to disable auto refreshing every time so you would have to reload the menu manuely.

Other suggestions you say are out of the scope of this utility. It is ment to enable quick access to folders in system dialogs not to do any make-up on them. If this is C code I would of course add that, but since it is already big speaking in AHK therms, I don't think so.... Also, it can not be done successifuly in AHK since I can not install system hook witch is required for this.


Thanx for your suggestions, I hope that I cleared some things for you.
The auto refreshing menu will probably be added as an option if I can't think some other way to check for changes. When using with Explorer it is much easier since I can check ony for Date changes... but TC will change other INI sections at will...

_________________