Titan wrote:
I guess he thought people wouldn't like having different texts on screen and on the clipboard...
...actually I wasn't thinking about that, but I do want the on-screen version "fixed" too, not just the clipboard-copied version...
Titan wrote:
...as I assumed users following that particular thread would review the
source code and apply their own mods.
...no offense, but your source code isn't actually "easy" to read...don't get me wrong it's very compact & probably efficient, but you use many single char vars & the text "codeblock-tab" isn't even in the source...so it's not easy, from looking at it, to piece together what prefs are available...for example the pref function (the most findable/identifiable piece of code {cuz of the string "pref"}) is complete gibberish, a bunch of single char vars (& I actually like JS & I am good with computers/programming, but that's just really complex to read). I did find it tho...the p array's 1st element is the prefix to all the prefs & the rest of the array is the prefs...but since I didn't write the code, I didn't, at first, know where to look. I agree on not repeating strings like "codeblock-" alot in code...but your use of arrays is very complex...& I don't know what the "ex" pref does, so I can't document it...
Why does the current version overwrite window.onload, instead of the addEventListener/etc code from before?
Why are some functions like...
Code:
this.expand = function (e) {
...instead of...
Code:
function expand(e) {
...you can give me the high-level explanation, I understand what that code does, but why that way & not some more readable way?
Bug Report: I know you'll be thrilled but I have a bug report for codeblock...
- Copy some code (via a forum Copy link) to the clipboard, paste in Notepad to see it's there
- Copy any other text to the clipboard, manually (not using a forum Copy link)...just type 123 in Notepad & copy it & paste it to make sure its on the clipboard
- On the forum, in the browser, press Back, check to make sure 123 is still on the clipboard, then press Forward...123 isn't on the clipboard anymore cuz the hidden swf re-copied the code when navigating Forward...
...I suppose you can delete (removeChild()) the div holding the Flash to make it not do this on pressing Forward? Ahh...I see it, you appendChild once & set innerHTML on Copy...I would appendChild & removeChild on each Copy...
Since I'm really curious, why is your Location: 0x00400000?
Titan wrote:
I will post instructions there soon (unless you want to do it).
...could you have a Prefs link that opens a div so people can set them? Again, I can help write some of it, but I don't wanna spend any time on something ignored...
Titan wrote:
Ideally phpbb would wrap code in <pre> tags and leave the formatting as the poster intended.
...yes, perhaps someone should look into where phpBB does this tab-to-3-spaces conversion & comment it out...& also wrap it in <pre> (or would <code> work & be more appropriate?)...& give it a class so you don't need to parentNode.parentNode to find the right element...
Titan wrote:
Perhaps phpbb3 does this?
...is that finally final yet?...is Chris gonna take the dive & convert? It looks nice but I hate the poster info being on the right side...maybe it's an admin panel pref? In any case I tested some code to swap the poster info to the left side, which could be added to the forum (if phpBB3 is installed here & also if it don't already have a pref for it)...
majkinetor wrote:
...must be pretty stupid...
Titan wrote:
...then call me stupid.
...(I agree with Titan)...again the world doesn't need any personal attacks. I find it obnoxious how non-US people always say "stupid Americans" & other insults...there's just no reason for it...all non-Americans are better...NOT!...no one is better, just be nice & get along...peace...
Sean wrote:
Actually that wasn't my real question.
...I don't know how that could not be your question...you were wondering if you needed to put that code in the location bar everytime you restarted Firefox, the answer is yes, the code he posted only sets a "Session Cookie"...but my answer was to set the expires on the cookie so it was no longer a session cookie...problem solved you no longer need to set it everytime you restart Firefox...
Sean wrote:
Anyway I decided to not use cookie and restored back my Firefox Cookie setting to "until Firefox is closed".
...ah, never used that pref before...how do you get by without any website storing any of your prefs?...I allow cookies but I periodically go thru them & completely block any sites that set "weird" cookies or extremely long expiring ones...plus I have Adblock Plus so the real ad/tracking cookies can't even be set anyway...but I need an extension to sort by "Expires" like Netscape 7.2 had (Firefox really made many unnecessary changes)...so I can find the extremely long expiring ones again...