tinku99 wrote:
AutoHotkey_L seems to leak more memory compared to official AutoHotkey in fileappend.
Thanks. I've found the problem -- the TextStream constructor does
mLocale = _create_locale(LC_ALL, ".0"). mLocale is used with _ismbblead_l to support multi-byte characters. However, _create_locale is failing and returning NULL. After a bit of debugging, I found that it doesn't accept 0, CP_UTF7 or CP_UTF8. The following can be found in
<Visual Studio dir>\VC\crt\src\getqloc.c (on my system at least):
Code:
// verify codepage validity
if (!iCodePage || iCodePage == CP_UTF7 || iCodePage == CP_UTF8 ||
!IsValidCodePage((WORD)iCodePage))
return FALSE;
So to get a valid _locale_t, we'll need to check for
cp == CP_ACP and pass
GetACP() instead. That's fair enough, but I had to ask myself "How is it leaking memory??". When the code above returns FALSE, _setlocale_nolock returns NULL to _create_locale, which is in
setlocal.c:
Code:
if ((retval->mbcinfo = _calloc_crt(sizeof(threadmbcinfo), 1)) == NULL)
{
...
}
_copytlocinfo_nolock(retval->locinfo, &__initiallocinfo);
if (_setlocale_nolock(retval->locinfo, _category, _locale) == NULL)
{
__removelocaleref(retval->locinfo);
__freetlocinfo(retval->locinfo);
_free_crt(retval);
retval = NULL;
}
The problem here is that it doesn't free
retval->mbcinfo, and there's no way for us to do so. Instead we'll need to duplicate the "codepage validity" checks above, avoiding _create_locale in those cases. I searched around a little while for any other references to this problem or somewhere to report the issue to MS, but gave up without finding anything.
I presume when you tested File.Write(), you weren't recreating the object repeatedly. This code exhibits the same memory leak, which makes sense in light of the issue I explained above:
Code:
Loop 100000
FileOpen(A_ScriptFullPath, 0)
Btw, I found that the following was sufficient for duplicating the problem without actually writing to any file:
Code:
Loop 100000
FileAppend, 0, nul
Downloads updated; see
here for changes.
Login
Register
FAQ
Search
