AutoHotkey Community

[evan]

Its not my first time using ReadProcessMemory functions to read 4byte value in a game client at certain memory address, but i always have difficulties copy and paste this and that... declaring the functions
so today, i made up my mind and wrap it up together into a library function

Here:

[evan]

of course, i do have the write memory address function too:

[Ice_Tea]

Hey

Well you should make 4 separate functions.
OpenHandle
ReadMemory
WriteMemory
CloseHandle

You're putting 3 functions into 1, which causes the whole thing to slow down.


As you see, it's way more efficient.

[evan]

can u show me the script u using to produce that result?
i assume it is:
OpenHandle
loop1000, ReadMemory
CloseHandle

i appreciate the suggestions, but i am aiming for all-in-one
if not all-in-one, why in the first place i need to make a function library
each for the 4 functions is just 1 line anyways

[[VxE]]

If you still want to have it 'all-in-one', then you could have a static variable in the function to hold the ProcessHandle, then use a special flag (in the processname parameter) to know when to close the handle.

Also, it might be nice to have the option for users who want to read chars one at a time, not 4 at a time

(also, for the readmemory function, the first param of the OpenProcess call only needs to be 16. Similarly, using PROCESS_ALL_ACCESS for the writememory function is definitely overkill)
_________________
Ternary (a ? b : c) guide     TSV Table Manipulation Library
Post code inside [code][/code] tags!

[evan]

o i see what u meant
but i dont quite get how it can be done to check should the program open/close handle from a library function
actually i dont really know what it meant by close, as it shows no difference with/without it
so lets say if i have a settimer every 1 second to check my current HP in a game client, the program will press certain key if HP low, or winKill the client when its 0
how should my open, read, close function approach?
usually i will just open the process from the beginning of my script and keep reading it until program exitapp

[Ice_Tea]

Hmm, Evan I'd like to write the function for you but atm I'm busy with another project...

It seems like you haven't understood that you can put multiple functions into 1 "library", meaning that you could put Openprocess,read/write-memory,Closeprocess into 1 single file...

Well the way you should build the script is like this:

[evan]

if i use this in library, it doesnt work
i guess because the ProcessHandle can not work outside the function so it wont react with ReadMemory()

[ahklerner]

you need to set ProcessHandle as a global var in each func it is used.
_________________

ʞɔпɟ əɥʇ ʇɐɥʍ

[Ice_Tea]

I'm on my way to bed, so I'll have to keep this short:
as ahklerner said, just put Processhandle as a global variable:

[evan]

thanks for the suggestion on globe var
i come out with this:

[Ice_Tea]

Nope a if statement shouldn't affect a lot at all... but the difference could be in our CPUs... a weaker CPU would give worse results...

[[VxE]]

Here's my cleanup of your ReadMemory() function:

Perks:
- Obtains the PID and handle to a process once for any number of calls to the same PROGRAM.
- Does not loop to obtain the 32bit int (increases speed marginally)
- Some error handling ("Fail" for failure to read or open process, and "Handle Closed: ?" when just closing the handle)
- My laptop clocked it at 26ms for 1000 calls using SetBatchLines, -1

This function should execute at a speed on par with simply looping ReadProcessMemory between OpenProcess and CloseHandle.

[evan]

excellent
i like the idea that include some error checking

i am glad that i share my script and your comments/suggestions will benefit my future memory reading projects. thanks

[Deicer]

Quick question.

When I use ReadMemory on a adress value eg. 2635 it returns 2635 (ok)
When I use ReadMemory on a adress value eg. HELLO it returns 1919595761 (Wrong)

How to convert/fix this, so it returns HELLO ?

ReadMemory looks like this: