AutoHotkey Community

[Drugwash]

That's better.
1. -1074331648 0 0
2. -1074303292 0 0
HeapAlloc seems to be OK.

[animeaime]

[animeaime]

Ok, since Menu_getMenuSize returns a blank, that means that there is a problem, and it's a simple enough function to disect.

[Drugwash]

Got my fingers in too many pies at this time.

First code:
1. 3352 0 0
2. 10
3. 0 0

Second code:
1. 1768 0 0
2. -1077926661 0 0
3. <blank>
4. -4 0

Guess third one is not right.

DllCallDebugger should simply show a message box whenever the result of a DllCall is non-zero (which is usually a sign of something going wrong) and apparently also shows the script log.
I believe the function should be called after each DllCall or at least in places where a failure is suspected. I only inserted the call after the first DllCall in Class.ahk.

[animeaime]

Yeah, that's the problem. Both codes should output the size. The second (which is what's used in the code) outputs a blank. Let me search the docs for the function to find out why. However, at least now the problem is found! Since the menu size is blank, the error cheking in the code prevents the move (because it thinks the original menu is empty).

So, I'll look that up and get back to you.

Hold on...-4.... that means you don't have the function in the dll...hmmm...

Try this. Maybe...just maybe, it's because it's a signed value and that's where the problem is.

[Drugwash]

Sorry for the late reply, I've been following another thread and got carried away.
Results:
1. 1868 0 0
2. 3217040635 0 0
3. 10
4. 0 0

I never liked signed integers and I guess the code can read my heart.

[animeaime]

no prob, thanks for all your help.

so that works! So running it with signed ints doesn't, but with unsigned ints it does?? If so, yeah! if that's it, I'll update the code to return uints when the return should be unsigned, and upload.

Can you run the two again? The one that failed before, and the ond that worked in the same script? Just want to make sure that that is the problem.

[Drugwash]

New tricks? You got me used to numbers.

Signed
3032 0 0
-1077926661 0 0
<blank>
-4 0

Unsigned
3032 0 0
3217040635 0 0
10
0 0

Signed Int malfunction confirmed.

[animeaime]

Awesome!!! That's an easy fix then. I'm hunting through the code to update all necessary occurances (and going to cache the remaining dll calls since we know it works fine for you). I'll make a post after I'm done.

Thank you so much for your help.
_________________
As always, if you have any further questions, don't hesitate to ask.

Add OOP to your scripts via the Class Library. Check out my scripts.

[animeaime]

Ok, it's up. I added some small optimizations by caching the remaining of the dll calls. Also, there was a bug that the code would return an error when trying to remove a "standard menu" item, this is now fixed. You can now remove items from the "standard menu". Also, there was another typo of a bug in Menu_Default that I fixed.

You can download the updated version here.
_________________
As always, if you have any further questions, don't hesitate to ask.

Add OOP to your scripts via the Class Library. Check out my scripts.

[Drugwash]

I wanted to keep it contained and only post testing results but... you changed things at the last moment.
#Include %A_ScriptDir%\..\Menu.ahk
#Include %A_ScriptDir%\..\MenuItem.ahk
#Include %A_ScriptDir%\..\Class.ahk
#Include %A_ScriptDir%\..\MenuLibraryTemplate.ahk

Those files are not there, not in the structure distributed in the zip at least. Personally I copied them to the lib subfolder in AHK but as they're distributed altogether you may as well use:
#Include Menu.ahk
#Include MenuItem.ahk
#Include Class.ahk
#Include MenuLibraryTemplate.ahk
or comment all of them while they're in lib (as I did now). Unless you're planning on changing distribution structure, that is.

This apart, it appears to work fine now. Only thing left is to remove the isChecked? 8 message box.

Thank you so much for fixing this 9x issue; believe me, few people around would've done that. You have my respect!

[animeaime]

Sorry, I used that for bug testing...I'll remove them and upload it again
_________________
As always, if you have any further questions, don't hesitate to ask.

Add OOP to your scripts via the Class Library. Check out my scripts.

[animeaime]

Ok, sorry about that, I removed those lines.

No, the structure is the same as before. When I put the compatablity to Win98 on AHK, it doesn't include the files in the library, so I manually included them. The structure remained the same: Menu.ahk, MenuItem.ahk, Class.ahk, and MenuLibraryTemplate.ahk all go in the library folder for easy inclusion.

Also, the MsgBox is intentional - to show the Menu_isChecked function, you can delete it without any side-effects. I didn't know a better way to show that feature. There was a post about how to see if a menu item was checked, and I said I would include a function in my menu wrapper.

I'm glad it works. Thank you so much for your help.
_________________
As always, if you have any further questions, don't hesitate to ask.

Add OOP to your scripts via the Class Library. Check out my scripts.

[animeaime]

Just thought of this.

As a note, the Test files can appear in any folder - as long as MenuLibraryTest.ahk and MenuLibrarySetup.ahk are in the same folder. This allows you to include the menu functionality from your own scripts - wherever they may be. Also, by using these files as a model, you can keep your project-specific menu functions in one file, separate from your project, to allow easy modification to the Menu / MenuItem object struture. Also, you can either have a separate file for your menu setup (what MenuLibraryTest is), and include it into your project, or add in the menu setup into your code. Just trying to keep your options open so that this library doesn't restrict your programming style or needs.
_________________
As always, if you have any further questions, don't hesitate to ask.

Add OOP to your scripts via the Class Library. Check out my scripts.

[Drugwash]

It's OK, either way. Was just thinking of users that may not be familiar with the lib structure and would get the same error, so having the script modules in a straight-away usable structure right after unpacking would save confusion and board posts.

Since the message box is intentional, everything should be fine now. If only I had the drive to work on all the half-baked projects I started and never finished...

Anyway, I'm glad it works too and hopefully it will be of use for many people. Thank you for your work and patience!