 |
AutoHotkey Community Let's help each other out
|
| View previous topic :: View next topic |
| Author |
Message |
SKAN
Joined: 26 Dec 2005 Posts: 7181
|
Posted: Thu Feb 05, 2009 8:24 pm Post subject: |
|
|
| "The most professional quality software ever written with AutoHotkey" |
|
| Back to top |
|
 |
SoggyDog
Joined: 02 May 2006 Posts: 626 Location: Greeley, CO
|
Posted: Thu Feb 05, 2009 9:02 pm Post subject: |
|
|
As always, quality words from majkinetor.
To be clear, though, I never claimed he has no right to Intellectual Property and he SHOULD be proud of his work; Paraphrasing SKAN in his post, this really IS about the most professionally written app I've seen here. Going back to my first response, I believe that this forum is a place for learning, which is what skwire did here and he did it by studying other peoples code, which he could not have done if nobody posted code here, so my statement that the app would not be here in it's current state without the help of other's code is accurate. Regarding malicious code, sure, anything you download can contain malicious code (which is why I don't download just every little thing) and it is further true that even when source code is made available, malicious code could still be obfuscated within and never seen. However, the chance of detecting malicious code in the source becomes zero when there is no code to investigate. Further still, malicious code is not my biggest issue here (that's what virus scanners are for), but rather that I learn best from the examples of others and it is very disappointing to not see any code here. I believe there is a lot that could be learned from this app. More disappointing still is the fact that, as you so eloquently stated, "By limiting access to the code, you limit yourself. When you share your code with the world, it starts improving others, and others start improving you, and all that is improving the world."
This dialog, of course, is what skwire was worried about, so...
If you read nothing else in this thread...
This app rocks... check it out! _________________
SoggyDog
Dwarf Fortress:
"The most intriguing game I've ever played." |
|
| Back to top |
|
 |
majkinetor
Joined: 24 May 2006 Posts: 4114 Location: Belgrade
|
Posted: Thu Feb 05, 2009 9:24 pm Post subject: |
|
|
| Quote: | | However, the chance of detecting malicious code in the source becomes zero when there is no code to investigate. |
Not quite. You can always disasemble the app. Thats how all AV companies do their job. It requires more effort, but its not zero
| Quote: | | I believe that this forum is a place for learning, which is what skwire did here and he did it by studying other peoples code, which he could not have done if nobody posted code here, so my statement that the app would not be here in it's current state without the help of other's code is accurate |
Like I said, its one thing to post a hardly usable script, another thing to post module, and yet another thing to post full blown application. You are right there are bunch of code snippets and functions here but there are not so many full blown applications like this one.
I agree with you that source code should be public, but I don't see it the way you do, to help other improve their coding. Althogh it would certanly help some people to realise some things, the script itself would probably be influenced more.
Anyway, if you want to find out something that interests you about the code I guess you can just ask skwire or anybody else.
After using it for a hour or so, I must say that I like it even more now. I am especially happy about perfectly done minibars. Although skinless version of WinAmp is 2x more light then Trout (on my pc Trout takes 2x more memory) I am still going to use it cuz .... its simply cool.
Suggestions:
* Think about "Add to / Enque in Trout" using DDE (toggled via menu) If you need help with it, let me know
* You should drop installer IMO, its ridicoulus to make installer for portable apps
* Color profiles would be awesome to have with several presets, like the black one you shown.
* Play history (which can be implemented similar to IE history)
* Drop the Playing column
* Playing position of Mp3 played from internet can not be set. _________________
 |
|
| Back to top |
|
 |
Petru
Joined: 17 Dec 2007 Posts: 139 Location: Galati, Romania
|
Posted: Thu Feb 05, 2009 9:49 pm Post subject: |
|
|
Well, majkinetor, disregarding the fact that pride is a sin, he shouldn't have posted this thread so we would never have found out that this is made with AutoHotkey. By posting this thread, the only thing he could tell us is "hey, look how smart I am! and you fools were not able to do this before I did, and as a consequence, I'll let you struggle by yourselves till you fall into the madness to do something like my thing. "
Maybe there should be a category for this: "Scripts without source", don't you think? I'm really intrigued by this and I'm guided by a strong sentiment of injustice and faith. |
|
| Back to top |
|
 |
SKAN
Joined: 26 Dec 2005 Posts: 7181
|
Posted: Thu Feb 05, 2009 10:49 pm Post subject: |
|
|
Gosh! I was among the ones who insisted skwire to post his application here.. and I feel so sorry about that.
Forgive me, skwire |
|
| Back to top |
|
 |
Petru
Joined: 17 Dec 2007 Posts: 139 Location: Galati, Romania
|
Posted: Thu Feb 05, 2009 11:06 pm Post subject: |
|
|
| SKAN wrote: | I feel so sorry about that.
Forgive me, skwire |
That's cute SKAN. Then I'll stop thinking of the source code. But I'll still pray for you both this night  |
|
| Back to top |
|
 |
Drugwash
Joined: 08 Sep 2008 Posts: 608 Location: Ploiesti, RO
|
Posted: Thu Feb 05, 2009 11:10 pm Post subject: |
|
|
@ SKWIRE:
My apologies, I wanted to stay clear from this topic as to not create "waves" but majkinetor's words - as an AHK master - made me come in.
We are not human beings unless we prove it by sticking together against all odds, helping each other.
After reading k3ph's post, I can fully understand the motivation behind turning to closed source. Yes, this can drive people wary and unfortunately breaks everything that can tell us people apart from other living creatures.
Anyway, the idea has already been voiced here: please create an alternative version of the script that does not contain the feature with the protected license. I'm sure nobody here wants to damage your intellectual property, but they/we do want to help improve/fix whatever can be improved/fixed.
Please think about it thoroughly. Thank you. |
|
| Back to top |
|
 |
majkinetor
Joined: 24 May 2006 Posts: 4114 Location: Belgrade
|
Posted: Thu Feb 05, 2009 11:18 pm Post subject: |
|
|
Petru is right about one thing. This is scripts & functions forum, perhaps better place is General section since this app clearly doesn't fit into this category without the source code. _________________
 |
|
| Back to top |
|
 |
SoggyDog
Joined: 02 May 2006 Posts: 626 Location: Greeley, CO
|
Posted: Thu Feb 05, 2009 11:27 pm Post subject: |
|
|
| SKAN wrote: | Gosh! I was among the ones who insisted skwire to post his application here.. and I feel so sorry about that.
Forgive me, skwire |
And he made the right choice...
Those of us that are disappointed to not see source code can (and will) get over it. _________________
SoggyDog
Dwarf Fortress:
"The most intriguing game I've ever played." |
|
| Back to top |
|
 |
k3ph
Joined: 21 Jul 2006 Posts: 221
|
Posted: Thu Feb 05, 2009 11:42 pm Post subject: |
|
|
| Drugwash wrote: | Anyway, the idea has already been voiced here: please create an alternative version of the script that does not contain the feature with the protected license. I'm sure nobody here wants to damage your intellectual property, but they/we do want to help improve/fix whatever can be improved/fixed.
Please think about it thoroughly. Thank you. |
Well, you can start to creating an entire opensource solution using BASS Library, feel free to it :]
Suggestion: consider the usage of gdip, as skwire mentioned before, he won't add skinning on trout.
By the way, Equalizers are finished and ready to be implemented on next version of Trout. Visualizers are coming soon, stay tuned on BASS Library.
By the way2, I'm looking for interested GUI guys to creating some cool GUI examples to handle BASS Library, poke me at IRC.
| SoggyDog wrote: |
And he made the right choice...
Those of us that are disappointed to not see source code can (and will) get over it. |
I've heard some rumors that someone started a project to replace AudioGenie <- idv1 and idv2 only? aw tags.dll supports reading for idv3, idv4 etc.. _________________ [ profile | ahk.net | ahk.talk ] |
|
| Back to top |
|
 |
Drugwash
Joined: 08 Sep 2008 Posts: 608 Location: Ploiesti, RO
|
Posted: Fri Feb 06, 2009 12:13 am Post subject: |
|
|
| Quote: | | Well, you can start to creating an entire opensource solution using BASS Library, feel free to it :] | I've already stated in the donationcoder thread it would be a waste of time. Dunno what others want, but I personally need tags fixed, seek/volume working and that's about all. I'm currently listening to my local tunes using Trout, because Winamp has long gone to hell from my system starting v5.5 beta when they dropped 9x support and GOMPlayer - the only media player I currently use - is not quite appropriate for audio files (bad quality). I don't even know or care what AudioGenie is.
But I may start my own project if the air stays so heavy here. Such a shame...  |
|
| Back to top |
|
 |
k3ph
Joined: 21 Jul 2006 Posts: 221
|
Posted: Fri Feb 06, 2009 12:23 am Post subject: |
|
|
| Drugwash wrote: | I've already stated in the donationcoder thread it would be a waste of time. Dunno what others want, but I personally need tags fixed, seek/volume working and that's about all. I'm currently listening to my local tunes using Trout, because Winamp has long gone to hell from my system starting v5.5 beta when they dropped 9x support and GOMPlayer - the only media player I currently use - is not quite appropriate for audio files (bad quality). I don't even know or care what AudioGenie is.
But I may start my own project if the air stays so heavy here. Such a shame...  |
Oh are you the one who posted some screenies on donationcoder thread? Well I think, in that time, Trout was using already AudioGenie to parse tags, so sorry, I can't help you with it. But when I get some free time I'll test some BASS Library tags plugin example over win9x.
What is your problem with seek/volume? As in BASS Library view, they should work properly.
After I finish documenting the examples, could you please try them? It would be nice to see it working on win9x _________________ [ profile | ahk.net | ahk.talk ] |
|
| Back to top |
|
 |
Drugwash
Joined: 08 Sep 2008 Posts: 608 Location: Ploiesti, RO
|
Posted: Fri Feb 06, 2009 12:32 am Post subject: |
|
|
I posted one pink screenshot, yes.
Problem is, can't change volume or seek by clicking the progressbars. Old version with sliders would've been just fine but I got there too late, unfortunately. If I had the code, I'd just make an IF A_OSType in Win9x {show sliders} ELSE {show progressbars} and get over with it.
And if those ID3 tags belong to AudioGenie, I'd just remove them altogether or find another compatible way to read them for Win9x.
Anyway, thank you for offering to help; I'll test whatever you can throw at me, time allowing. |
|
| Back to top |
|
 |
k3ph
Joined: 21 Jul 2006 Posts: 221
|
Posted: Fri Feb 06, 2009 12:45 am Post subject: |
|
|
| Drugwash wrote: | | If I had the code, I'd just make an IF A_OSType in Win9x {show sliders} ELSE {show progressbars} and get over with it. |
According to my mind, we've tested sliders progression bar a LOT and the results weren't good. The sliders were buggy jumping incorrectly and displaying the wrong time, maybe Skwire can give you more details about that.
| Drugwash wrote: | | Anyway, thank you for offering to help; I'll test whatever you can throw at me, time allowing. |
Nice, if I get my new box I could handle it alone, but more hands are always welcome. _________________ [ profile | ahk.net | ahk.talk ] |
|
| Back to top |
|
 |
Drugwash
Joined: 08 Sep 2008 Posts: 608 Location: Ploiesti, RO
|
Posted: Fri Feb 06, 2009 1:03 am Post subject: |
|
|
Currently clicking the seekbar at any place only rewinds approx. 500ms back and clicking the volume bar won't react in any way. That's not a problem for me personally since I have my own OSD voume control, but I'm not a selfish person.
Sliders would definitely be more helpful. Maybe I should create myself some testing scripts.
Regardless, I should be fair and say this is a good application and it deserves the right appreciation. The more the frustration that I can't wholeheartedly say "in your face, AOL, for your Winamp's dropped 9x support".  |
|
| Back to top |
|
 |
|
|
You can post new topics in this forum You can reply to topics in this forum
|
Powered by phpBB © 2001, 2005 phpBB Group
|