AutoHotkey Community

Guest_AutoHotkey_L · Guest

At:

http://www.autohotkey.net/~Tuncay/ini/ini.html#ini_getAllValues

(and in the source I have here) I currently see both:

Tuncay not logged in · Guest

Yes thats right. Normally I used the comma separated to separate the items. That time, I was reading different specifications about the ini format and different implementations. To me it was sure enough to use the comma. I do not think any section or key name would contain a comma. All other functions are based on this specification. So there is no need for a change at this topic.

Later, I added the function getAllValues(). A value can contain nearly any character and this would be a problem. The only one character which cannot contain is the new line character. Because the newline ends the value.

So it is correct. Smile

Tuncay not logged in · Guest

OH sorry, I did not see the copy and paste error!

Yes you are right. Sorry for the confusion. new line is used, and the text at Returns is not correct. I forgot after pasting the text to edit it. Thx for reporting that.

tidbit · Joined: 09 Mar 2008 Posts: 1808 Location: Minnesota, USA

Great function.

How would I go about speeding up ini_insertvalue()?

i have a list of over 200,000 words hat I need organized and after 8k it gets slow. takes about 30 minutes for the whole thing.

i tried adding VarSetCapacity(_Content, 10240000) (10Mb) to the function and well, it only takes 3 minutes, great! however, it then erases the contents of _Content.

from what I was told, if i figured out a way to use _Content.= insted of _Content:= VarSetCapacity() should work. and then it would greatly increase the speed.
only issue, i have no clue how!
any help? thanks!
_________________
rawr. be very afraid
*poke*
Note: My name is all lowercase for a reason.
Even monkeys fall from trees. - Japanese proverb

Tuncay · Joined: 07 Nov 2006 Posts: 1886 Location: Germany

Thanks tdibit.

The library is not designed and tested for use with large data. At every call of ini_insertValue() the whole content is replaced with inserted content. There is not much room for optimizing the function.

But if you need to call the function many times, I would recommend to set PreserveSpace parameter to true.

Add SetBatchLines, -1 to your script before calling this function.

Can you avoid so many calls of ini_insertValue()? If it is possible, I strongly encourage you to add the data into a variable. And after your variable is constructed, then update the ini content once with the ini_insertValue() function.

Another suggestion is, if you operate on large ini file, work on one section only, instead of whole content. Extract the section ini_getSection() and after work is done, update the section in orginal data with ini_replaceSection().

... to speed up the function itself, I do not have any idea yet. The whole library is designed for Vanilla Ahk. And generally said, Vanilla Ahk is faster in my tests than AHK_L.

Current code of function ini_insertValue():

tidbit · Joined: 09 Mar 2008 Posts: 1808 Location: Minnesota, USA

1) i'm using the main AHK.
2) the text is in a .txt file loaded into ahk with fileread.
3) the contents is on new-lines and tab delimited.
-- i write the first word according to the value of the second word (word1 %A_tab% word2)
4) I write word 1 to the appropriate key based on word2
5) i can not pre-organize it.

what i'm trying to do is organize a dictionary based on part-of-speech.

here is my code as of now:

Tuncay · Joined: 07 Nov 2006 Posts: 1886 Location: Germany

1. Where are your elses?
2. Try VarSetCapacity() your variable before Loop begins.
3. Set PreserveSpace to true.

Tuncay · Joined: 07 Nov 2006 Posts: 1886 Location: Germany

Here is an alternative way what I was talking about:

tidbit · Joined: 09 Mar 2008 Posts: 1808 Location: Minnesota, USA

else isn't needed since the Continues skip everything else.

first script is slow.
second script is fast and good! only issue: it doesnt write to the ini.
I would also like to preserve my format, not ini_insertvalue(ini, "N", "Noun", ini_%A_LoopField%_Noun).

edit: nevermind. it works with some light modification Smile

_________________
rawr. be very afraid
*poke*
Note: My name is all lowercase for a reason.
Even monkeys fall from trees. - Japanese proverb

Tuncay · Joined: 07 Nov 2006 Posts: 1886 Location: Germany

tidbit · Joined: 09 Mar 2008 Posts: 1808 Location: Minnesota, USA

heres the working code. it takes 4.5 minutes. pretty good.

Tuncay · Joined: 07 Nov 2006 Posts: 1886 Location: Germany

Lexikos · Joined: 17 Oct 2006 Posts: 7299 Location: Australia

tidbit, the following seems to be slightly faster than your large if..else ladder:

tidbit · Joined: 09 Mar 2008 Posts: 1808 Location: Minnesota, USA

Ha, crap. I changed the case of everything to Title Case before the parse Sad

thanks for the catch!

grr. have to redo everything I did to the database and I'm getting more complications then i ever had...
edit: fixed Smile

_________________
rawr. be very afraid
*poke*
Note: My name is all lowercase for a reason.
Even monkeys fall from trees. - Japanese proverb

DeWild1 · Joined: 30 Apr 2006 Posts: 358 Location: Shigle Springs

Very cool. Thank you for your hard work.
I have read much and you have helped me understand functions better.

Q: I need to go through