Script clicker when an image is found

[Tibro]

Good afternoon.
I want to write a script that will work in a mini-game like "Flappy Bird"
Let's say fish "X" swims and there is a hook "Y". The hook moves only when the LMB is held down and goes out to the standard position if the LMB is released.
Need a script.
So that when a picture "X" is found on the screen, the script clicks on the mouse (which constantly goes up) and holds the picture "X" at the position of the picture "Y"

But at the very beginning I faced a similar problem.
The script does not want to react to the PNG that I cut out.
Tried different sizes. It does not even react to PNG not in the game itself, but on the folder in which it is located. But it reacts to the screen made in the browser.

Code: Select all

F2::

 imgFound := false
 while(imgFound = false)
 {
   
  ImageSearch, X, Y, 0, 0, A_ScreenWidth, A_ScreenHeight, test.png
  if (x тут скобки угловые "")

  {
   click, %x%, %y%
   Sleep 100
   click, %x%, %y%
   Sleep 100
   click, %x%, %y%
   MsgBox Изображение найдено в координатах x=%x%, y=%y%.
   imgFound := true
  }
 }
return

Why doesn't he react?

What am I doing wrong?
If you help me in writing or just to understand why it does not work, then I will be very grateful!

[boiler]

I’m not sure why you have this line like this:

Code: Select all

  if (x тут скобки угловые "")

It apparently should be:

Code: Select all

  if (x != "")

That should work, but I would go with this instead:

Code: Select all

  if !ErrorLevel

[Tibro]

I’m not sure why you have this line like this:

Code: Select all

  if (x тут скобки угловые "")

It apparently should be:

Code: Select all

  if (x != "")

That should work, but I would go with this instead:

Code: Select all

  if !ErrorLevel

It works, completely, but not on this img and not in the game. If a
Run the script in the browser, for example, with another png, then it works fully, but if I run it in the game with this png, then it does not work at all

[Tibro]

I’m not sure why you have this line like this:

Code: Select all

  if (x тут скобки угловые "")

It apparently should be:

Code: Select all

  if (x != "")

That should work, but I would go with this instead:

Code: Select all

  if !ErrorLevel

You didn't help.
I wrote earlier that the script does not work only in the game.

It works in the browser, outside the browser, but not in the game.
And do not work with the PNG file that I cut from the game. It works with other PNG files from the browser, but not from the game.

[boiler]

You didn't help.
I wrote earlier that the script does not work only in the game.

OK. You include a line like if (x тут скобки угловые "") and expect me not to point it out? If it works, it's despite that line, not because it does anything useful. Good luck.

[Tibro]

You didn't help.
I wrote earlier that the script does not work only in the game.

OK. You include a line like if (x тут скобки угловые "") and expect me not to point it out? If it works, it's despite that line, not because it does anything useful. Good luck.

I took into account your remark and I am grateful for it. I fixed it and did as you said. I appreciate it and want to write correctly right away, so I am very grateful.
But we are talking about the problem of the performance of this script
I need to understand why it doesn't work in general

[Tibro]

Code: Select all

F2::

 imgFound := false
 while(imgFound = false)
 {
   
  ImageSearch, X, Y, 0, 0, A_ScreenWidth, A_ScreenHeight, test.png
    ;if (x != "")
     if !ErrorLevel
  {
   click, %x%, %y%
   Sleep 100
   click, %x%, %y%
   Sleep 100
   click, %x%, %y%
   MsgBox Screen Coords x=%x%, y=%y%.
   imgFound := true
  }
 }
return
 

[boiler]

Can you post the test.png image?

[Tibro]

Can you post the test.png image?

[boiler]

That's the problem. There are a couple issues with your reference image. It's way too big. You need to crop it down to only the part that you're searching for. And you can't use a transparent background. If you want it to treat the parts around it as transparent (so it will find it no matter what background is around it), then you have to make that a certain color and use the *Trans option in ImageSearch.

Here is how you would crop it so that it doesn't include any background (don't include any edges that could have the background blended in):

test_cropped.png (1.03 KiB) Viewed 792 times

If you want to include pretty much the whole fish, then you need it to ignore the background, and you do that by using a trans color that you will tell ImageSearch to ignore. And you have to color over edges too since those would be partially shown with the background blended in and you want it to ignore those too. You want just the part that would be pure opaque colors that are the same every time, so you have to liberally color over all the edge pixels. And when you color it, you can't use a brush tool that has blended edges. It needs to be a pencil tool that paints only pixels of the pure color. And the color can't merely look like the color (like any red). It has to be the exact numerical value that you're going to put in your ImageSearch command (such FF0000 to match "Red" or the value itself) Like this:

test_red.png (2.44 KiB) Viewed 792 times

And your command would look like this:

Code: Select all

ImageSearch, X, Y, 0, 0, A_ScreenWidth, A_ScreenHeight, *TransRed test_red.png ; or the equivalent *TransFF0000

And you might want to specify some allowable variation in the color values:

Code: Select all

ImageSearch, X, Y, 0, 0, A_ScreenWidth, A_ScreenHeight, *10 *TransRed test_red.png

[Tibro]

That's the problem. There are a couple issues with your reference image. It's way too big. You need to crop it down to only the part that you're searching for. And you can't use a transparent background. If you want it to treat the parts around it as transparent (so it will find it no matter what background is around it), then you have to make that a certain color and use the *Trans option in ImageSearch.

Here is how you would crop it so that it doesn't include any background (don't include any edges that could have the background blended in):
test_cropped.png


If you want to include pretty much the whole fish, then you need it to ignore the background, and you do that by using a trans color that you will tell ImageSearch to ignore. And you have to color over edges too since those would be partially shown with the background blended in and you want it to ignore those too. You want just the part that would be pure opaque colors that are the same every time, so you have to liberally color over all the edge pixels. And when you color it, you can't use a brush tool that has blended edges. It needs to be a pencil tool that paints only pixels of the pure color. And the color can't merely look like the color (like any red). It has to be the exact numerical value that you're going to put in your ImageSearch command (such FF0000 to match "Red" or the value itself) Like this:
test_red.png


And your command would look like this:

Code: Select all

ImageSearch, X, Y, 0, 0, A_ScreenWidth, A_ScreenHeight, *TransRed test_red.png ; or the equivalent *TransFF0000

And you might want to specify some allowable variation in the color values:

Code: Select all

ImageSearch, X, Y, 0, 0, A_ScreenWidth, A_ScreenHeight, *10 *TransRed test_red.png

Thank you very much! This will come in handy in the future, but not worked id game) shit(

[Tibro]

Outside of the game it works great. I can make a video for you to better understand.

[Tibro]

I decided to try using windowed mode - it did not help