Page 2 of 3

Re: Solved Button proposal

Posted: 18 Jun 2016, 22:06
by tank
will do. Ill elevate the priviledges between 6pm and midnight eastern time and be available if needed

Re: Solved Button proposal

Posted: 19 Jun 2016, 02:16
by joedf
Okay great :)

Re: Solved Button proposal  Topic is solved

Posted: 20 Jun 2016, 22:42
by joedf
Solved button! :)

Re: Solved Button proposal

Posted: 21 Jun 2016, 00:51
by Nextron
So that not everybody needs to create a new thread to find out where the button is...
Image

It's the little cog next to every post in a thread you started, to mark a post as the solution. It's not enabled in all subforums? Wouldn't the green checkmark displayed next to solved threads be better suited as an icon?

Re: Solved Button proposal

Posted: 21 Jun 2016, 04:05
by lexikos
Inspecting the button, I see there is some CSS already defining a checkmark background-image, but it's being overridden somehow and also being obscured by a :before { content: '\f013'; ... } rule that adds the cog (it's actually text).

I got the checkmark to show by randomly disabling CSS rules, and changing '\f013' to ' '. The checkmark is grey until you hover over it, then it is green. For that to work with our current default theme, we'd need to change the background colors (default and hover) of the button as well.

What I think would fit the theme better is a green (of the same shade as the blue buttons) button with a white checkmark.

Re: Solved Button proposal

Posted: 21 Jun 2016, 12:07
by joedf
I didn't enable it everywhere since I have to do it manually for every single one. Shall I enable it for all forums?
Yes, noticed that it is a cog in the main theme. In prosilver, it is a checkmark. When I do have time I will check it out. :)

Re: Solved Button proposal

Posted: 21 Jun 2016, 16:33
by lexikos
"Solved" topics do not make sense on all forums.

Re: Solved Button proposal

Posted: 21 Jun 2016, 16:50
by joedf
Understood. Here are the current settings.

Code: Select all

Yes, moderator
	About This Community
	Forum Issues
	Bug Reports
	Offtopic
Yes
	Ask For Help
No
	Everything else...

Re: Solved Button proposal

Posted: 21 Jun 2016, 16:52
by lexikos
What about the "international" sub-forums?

Re: Solved Button proposal

Posted: 21 Jun 2016, 16:57
by joedf
Right! I'll do the same for them too.
-
Note on the styling: The topic title that would normally appear (currently being hidden by some js) above every post has the checkmark also and should be modified to at least show which post is the 'Answer' post. Otherwise, there is simply the solved button to be styled correctly under the main theme.

Re: Solved Button proposal

Posted: 21 Jun 2016, 17:08
by joedf
"Ask For Help" (yes) and "General/offtopic" (yes, moderator) have been set for Deutsch (German), 中文 (Chinese), Español (Spanish), Русский (Russian) and Français (French).

Re: Solved Button proposal

Posted: 22 Jun 2016, 22:24
by lexikos
It should also be enabled for moderators on the v2 subforum, for bugs and change requests.

Re: Solved Button proposal

Posted: 23 Jun 2016, 09:51
by joedf
Yes, right. "AutoHotkey v2 Development" has been set to "yes, moderator".

Re: Solved Button proposal

Posted: 24 Jun 2016, 12:45
by joedf
I've made a test as a greasemonkey script to highlight the solved topic.
screenshot

Code: Select all

// ==UserScript==
// @name        AHK-Forum display solved h3 title
// @namespace   autohotkey.com
// @include     http://autohotkey.com/boards/viewtopic.php*
// @include     https://autohotkey.com/boards/viewtopic.php*
// @version     1
// @grant       none
// @author      joedf
// timestamp 15:11 2016/06/24
// ==/UserScript==
window.onload = function () {
  p = document.getElementsByClassName('postbody');
  n = p.length;
  for (i = 0; i < n; i++) {
    if (p[i].getElementsByTagName('h3') [0].contains(document.getElementsByClassName('icon_solved_post') [0])) {
      p[i].getElementsByTagName('h3') [0].style.display = 'inline';
      m = p[i].getElementsByTagName('div') [0];
      m.style.border = '2px solid lime';
      m.style.padding = '4px';
      m.style.backgroundColor = 'lightgoldenrodyellow';
      //m.style.maxWidth="99.4%";
      break;
    }
  }
}

Re: Solved Button proposal

Posted: 28 Jun 2016, 17:50
by TAC109
I've just tried to test the 'solved' button in 'off topic' but can't find it any more, in any board style. I was trying to test if, having turned it on, it could be turned off.

There seems to be a sprinkling of ticks in the 'ask for help' forum which don't seem to be related to whether the OPs question has been solved or not. This would indicate that it is not being used as expected, or the icon is too obscure, or some other reason. I think someone should revisit the implementation of this proposal.

Re: Solved Button proposal

Posted: 28 Jun 2016, 19:11
by joedf
joedf wrote:Understood. Here are the current settings.

Code: Select all

Yes, moderator
	About This Community
	Forum Issues
	Bug Reports
	Offtopic
Yes
	Ask For Help
No
	Everything else...
It was set for Moderators, should I enable it for all? :0

Re: Solved Button proposal

Posted: 28 Jun 2016, 19:36
by TAC109
It would certainly be useful in 'off topic'.

However I believe my second paragraph should be addressed too.

Edit:- Also whether the solved tick can be turned off? (I was unable to test this)

Re: Solved Button proposal

Posted: 01 Jul 2016, 16:12
by tank
what would ever be "SOLVED" in offtopic?

Re: Solved Button proposal

Posted: 01 Jul 2016, 17:40
by Xtra
tank wrote:what would ever be "SOLVED" in offtopic?

I'd guess an off topic question? Yea i know how common is that... :facepalm:

Re: Solved Button proposal

Posted: 01 Jul 2016, 19:17
by TAC109
As there is no 'test' forum, 'off topic' would seem to be the closest one to use for testing forum facilities.