Page 7 of 9

Re: Forum upgraded to phpBB v3.1.x

Posted: 27 May 2015, 16:07
by Guest
Personally I'm not a big fan of italics in the code box it makes it more difficult to read for me. Colors are fine (default theme) and like the upgrade, thanks for all the efforts so far. (

Re: Forum upgraded to phpBB v3.1.x

Posted: 27 May 2015, 17:28
by guest3456
Guest wrote:Personally I'm not a big fan of italics in the code box it makes it more difficult to read for me. Colors are fine (default theme) and like the upgrade, thanks for all the efforts so far. (
Def +1. I wondered what was off. I agree with this for the actual code. I think in the current iteration I've seen these as italic: built-in functions, built-in variables, keywords such as "class" and "static", and #directives

But I do think comments should be italicized.

Re: Forum upgraded to phpBB v3.1.x

Posted: 28 May 2015, 01:37
by Guest
@guest3456 indeed italics for comments I don't have a problem with either as that is usually a line or block of text, it is the keywords etc as you indicate that I have some trouble with.

Re: Forum upgraded to phpBB v3.1.x

Posted: 28 May 2015, 01:57
by jNizM
How about a feature to link user and they got a notification about it?
Because not everyone read everything on this forum and with this feature we can give him a hint to look into it.

like [link]lexikos[/link] or something else

Re: Forum upgraded to phpBB v3.1.x

Posted: 28 May 2015, 03:49
by nnnik
jNizM wrote:How about a feature to link user and they got a notification about it?
Because not everyone read everything on this forum and with this feature we can give him a hint to look into it.

like [link]lexikos[/link] or something else
Working on it.

Re: Forum upgraded to phpBB v3.1.x

Posted: 28 May 2015, 04:03
by lexikos
@Guests: I agree in an opposite sort of way. In some scripts (especially where the comment is a line, between code lines), I think the italic comments are less readable. Since the keywords are short, the italics never bother me at all. I'm considering removing all italics.

@jNizM: <-- This is more intuitive (see, for example, the post above yours). There is this extension in development. I might try it on my test setup.

Re: Forum upgraded to phpBB v3.1.x

Posted: 28 May 2015, 04:11
by jNizM
As long the one are linked to @ gets the notification, ok.
Thanks for working on it.

I hope we dont get double notifications for @ and new post notification =)

Are spam notifications fixed?

I think this is useless:
Report closed by joedf for: "mmxsadgasydheyiccrmsgxqfepehwk"

Same for "self" deleted reply's by owner
Reply from TLM in topic: "Test your Forum Posts"

Re: Forum upgraded to phpBB v3.1.x

Posted: 28 May 2015, 09:20
by joedf
Ahh I got it!!!!
UCP -> Board Preferences -> Edit notification options
Uncheck all under "Notification type : Someone reports a post"
http://ahkscript.org/boards/ucp.php?i=u ... on_options

As for the @mention I saw it before but was hesitant :p
If it works fine, then great! :)

Re: Forum upgraded to phpBB v3.1.x

Posted: 28 May 2015, 09:24
by jNizM
You or me?
Image

Re: Forum upgraded to phpBB v3.1.x

Posted: 28 May 2015, 09:32
by joedf
Hmmm I think it's for moderators only...
Didn't see anything for "closed reports"...
But I think I know where to modify phpbb to block these...
Should I go ahead and try that?

Re: Forum upgraded to phpBB v3.1.x

Posted: 28 May 2015, 09:40
by joedf
I was wondering what was different... :P
The forum descriptions are now shown directly, how was that changed?

Edit: I'm guessing the .html templates, facepalm totally forgot about those for a second there :p

Re: Forum upgraded to phpBB v3.1.x

Posted: 29 May 2015, 01:45
by lexikos
joedf wrote:The forum descriptions are now shown directly, how was that changed?
https://github.com/ahkscript/phpbb31_st ... a190d0a193
But I think I know where to modify phpbb to block these...
Should I go ahead and try that?
No. Do not modify phpbb itself. If they really can't be turned off, write an extension.

Re: Forum upgraded to phpBB v3.1.x

Posted: 29 May 2015, 10:42
by joedf
Alright thanks, I'll explore extensions.

Re: Forum upgraded to phpBB v3.1.x

Posted: 29 May 2015, 20:14
by lexikos
jNizM wrote:I think this is useless:
Report closed by joedf for: "mmxsadgasydheyiccrmsgxqfepehwk"
After looking into it further, I realized that there's no option in the UCP because the notification is only generated if the user requested it. See below, which appears on the "Report this post" page:
Notify me:
Informs you when your report is dealt with.
joedf wrote:But I think I know where to modify phpbb to block these...
What were you planning to do? I don't think it would be appropriate to block all such notifications.
joedf wrote:Alright thanks, I'll explore extensions.
I think an extension probably wouldn't be able to disable or modify the behaviour of specific kinds of notifications, but one could probably switch the "Notify me" option off by default for spam reports. (Edit: Apparently it is possible for an extension to replace built-in notification classes; but I don't think we need to.)

If you do make any changes to phpbb, create a repo at ahkscript first. Do the same if you write an extension, so we might add to it in future.

Re: Forum upgraded to phpBB v3.1.x

Posted: 08 Jun 2015, 07:55
by vasili111
Can you please add subsilver theme (old forum theme)?
Here ( http://phpbb3.x-tk.ru/viewtopic.php?p=550095 ) is subsilver2 for 3.1.х. Latest version can be downloaded with this link ( http://allanstylephpbb3.x-tk.ru/viewforum.php?f=4 ).

Also please add mod for large images ( https://github.com/DavidIQ/phpBB-ReIMG-Image-Resizer ) so that on click it will zoom to actual image size.

Re: Forum upgraded to phpBB v3.1.x

Posted: 08 Jun 2015, 19:44
by lexikos
We already have lightbox installed for large images.
https://github.com/VSEphpbb/lightbox

Re: Forum upgraded to phpBB v3.1.x

Posted: 09 Jun 2015, 01:19
by vasili111
lexikos wrote:We already have lightbox installed for large images.
https://github.com/VSEphpbb/lightbox
Why that image is not zooming? http://ahkscript.org/boards/viewtopic.p ... 647#p44647

Re: Forum upgraded to phpBB v3.1.x

Posted: 09 Jun 2015, 01:37
by jNizM
@vasili111
For me it is zooming:
Image

Re: Forum upgraded to phpBB v3.1.x

Posted: 12 Jun 2015, 05:31
by Guest
Perhaps it is me but when using Firefox (also tested with all addons disabled using firefox.exe -safe-mode - firefox 39) when I paste something which starts with %A_ like the built-in variables the %A is replaced with a newline character so instead of

Code: Select all

%A_Index%
I end up with

Code: Select all


_Index%


If I just type it there isn't any problem, only when pasting. Doesn't happen on Opera, Chrome.

Perhaps another Firefox user could also test this? It might very well have nothing to do with the forum and be a generic firefox bug or something specific to my computer.

Re: Forum upgraded to phpBB v3.1.x

Posted: 12 Jun 2015, 08:25
by GeekDude
Seems to work fine on my firefox 38.0.5