Page 1 of 6

Fixing codeboxes

Posted: 27 Oct 2018, 22:33
by tank
There may be some short temporary outages as a result but the risk doesn't merit taking the entire forum offline. I intend to be done by 6AM GMT

Re: Fixing codeboxes

Posted: 27 Oct 2018, 22:44
by tank
test

Code: Select all

msgbox testtest
msgbox testtest
msgbox testtest
msgbox testtest
msgbox testtest
msgbox testtest
msgbox testtest
msgbox testtest
msgbox testtest
msgbox testtest
msgbox testtest
msgbox testtest
msgbox testtest
msgbox testtest
msgbox testtest
msgbox testtest
msgbox testtest
msgbox testtest
msgbox testtest
msgbox testtest
msgbox testtest
msgbox testtest
msgbox testtest
msgbox testtest
msgbox testtest
msgbox testtest
msgbox testtest
msgbox testtest
msgbox testtest
msgbox testtest
msgbox testtest
msgbox testtest
msgbox testtest

Code: Select all

select * from test where date = now()

Re: Fixing codeboxes

Posted: 27 Oct 2018, 23:23
by tank

Code: Select all

msgbox test

Re: Fixing codeboxes

Posted: 28 Oct 2018, 00:04
by tank
well apparently codebox plus is no longer supported so this is going to take more work than expected

Re: Fixing codeboxes

Posted: 28 Oct 2018, 07:33
by burque505
Thanks for keeping it at it, tank. Greatly appreciated.
Regards,
burque505

Re: Fixing codeboxes

Posted: 28 Oct 2018, 19:19
by Scr1pter
For me the codebox doesn't work at all anymore!
Can you please re-check it?

Code: Select all

This is some code
Image

Regards

Re: Fixing codeboxes

Posted: 28 Oct 2018, 19:24
by joedf
Maybe we should try this extension? It uses highlight.js
https://github.com/s9e/phpbb-ext-highlighter

Re: Fixing codeboxes

Posted: 28 Oct 2018, 19:59
by tank
I just restored from a backup before i started working on the code boxes
this is a strange problem

Re: Fixing codeboxes

Posted: 28 Oct 2018, 20:08
by tank
Its only new posts or edits

Re: Fixing codeboxes

Posted: 28 Oct 2018, 20:25
by tank
new posts will do code view correctly

Re: Fixing codeboxes

Posted: 29 Oct 2018, 02:57
by just me

Code: Select all

MsgBox, Code boxes don't work!

Re: Fixing codeboxes

Posted: 29 Oct 2018, 05:25
by DRocks
Thank you for the work you are doing.. i was go8ng to ask what was happening with code blocks as there were no indention and color variance :D
Must be a puzzle to sort out. Thanks for all efforts

Re: Fixing codeboxes

Posted: 29 Oct 2018, 07:54
by Scr1pter
To be honest I don't get why all these problems had to appear.
Everything started after the forum update.

Can't you just set it back to date X where everything used to work?
Is the new "upgrade" really mandatory?

This is such a great forum, but due to these issues, especially with the code boxes, it's currently not fun :(
I even resigned myself to using the black theme.

P.S: Don't take my post as offense.

Regards

Re: Fixing codeboxes

Posted: 29 Oct 2018, 10:20
by nnnik
Yes the update was necessary.
We were getting an increased influx in spam that easily passed our Recaptcha - a better captchawas not actively available for that version of the board.
The second problem was that the forum itself started to show signs of bugs.

An update has been delayed for a long time since many of our specially created plugins no longer work for this new php BB version.
And as such it has become an increasingly problematic change.

Re: Fixing codeboxes

Posted: 29 Oct 2018, 12:41
by joedf
We need to keep up to date for security, compatibility, performance, etc.
Anyway, I think I found some fixes for codebox plus on phpbb v3.2.x

https://www.phpbb.com/customise/db/mod/ ... pic/194091

No time for me to focus on this now, but I don't know what tank did. Codebox plus is removed, but yet appears to be installed according to the ACP...

Re: Fixing codeboxes

Posted: 29 Oct 2018, 12:51
by nnnik
The code box in his post does not work for me.

Re: Fixing codeboxes

Posted: 29 Oct 2018, 13:01
by tank
ok damn they worked for me when i posted something must have gone wrong after i logged off
work on it tonight

Re: Fixing codeboxes

Posted: 29 Oct 2018, 14:07
by joedf
nnnik wrote:
29 Oct 2018, 12:51
The code box in his post does not work for me.
Pictures?
tank wrote: ok damn they worked for me when i posted something must have gone wrong after i logged off
work on it tonight
Looking forward to it :)

Re: Fixing codeboxes

Posted: 30 Oct 2018, 07:31
by tank
JoeDF i think it is time to try your IDEA

Re: Fixing codeboxes

Posted: 30 Oct 2018, 19:54
by joedf
You mean my suggested fix? I'll to get to it Thu or Fri afternoon. If not, definitely the weekend.
Or did you mean trying out the Highlight.js extension?