Page 1 of 2

Codebox theme

Posted: 14 Nov 2018, 05:59
by mikhail22
Syntax highlighting works today on the forum. But please, not this dark theme!
Dark boxes looks awful, please make some light theme.

Re: Codebox theme

Posted: 14 Nov 2018, 10:22
by gregster
Be happy, in the dark 'Digi' theme, which I prefer, syntax highlighting doesn't work at all... I think it's all still in the works.

Re: Codebox theme

Posted: 14 Nov 2018, 13:10
by joedf
SO SORRY! I have not gotten to it yet. I forgot last night... :p
I will have dark syntax highlighting on Digi and light syntax highlighting on Simplicity.

Re: Codebox theme

Posted: 14 Nov 2018, 13:19
by gregster
joedf wrote:
14 Nov 2018, 13:10
SO SORRY! I have not gotten to it yet. I forgot last night... :p
I will have dark syntax highlighting on Digi and light syntax highlighting on Simplicity.
Thank you for your work, Joe!

Re: Codebox theme

Posted: 14 Nov 2018, 14:00
by mikhail22
gregster wrote:
14 Nov 2018, 10:22
Be happy, in the dark 'Digi' theme, which I prefer, syntax highlighting doesn't work at all... I think it's all still in the works.
That's right - with Digi i see no syntax in codeboxes , it's all green Courier font .
In Prosilver and Simplicity there is syntax highlighting, but with dark theme.
Light global theme should be with light codeboxes and dark theme with dark codeboxes, if it's possible ;)

Re: Codebox theme

Posted: 14 Nov 2018, 23:46
by joedf
Okay, it should be more or less good now :+1:

Re: Codebox theme

Posted: 14 Nov 2018, 23:53
by joedf
Logos should be good too.

Re: Codebox theme

Posted: 15 Nov 2018, 00:14
by TAC109
@Joedf Thanks for all your work on the forums, but still some problems:-

Prosilver theme has no syntax colouring in the code boxes.

Clicking on a command in the code box does not link to help.

phBPP still appears in the heading at top of page on left (not AHK logo) - this is when using prosilver theme.

Re: Codebox theme

Posted: 15 Nov 2018, 00:57
by hoppfrosch
@Joedf: Many thanks for your efforts as well from me.

There are still following problems with light-themed codeboxes in Simplicity here:
* Opening a post, the codeboxes are expanded by default (should be collapsed by default - shouldn't they?)
* Unless the codeboxes are already expanded, "Expand view" is shown on top off the codebox
* Clicking "Expand view" toogles it to "Collapse view" - nothing else happens
* Clicking "Collapse view" collapses the codebox .... BUT: the space previously occupied by the expanded view does not collapse: within this space there is the collapsed codebox and a lot of empty space ....

Using latest firefox 63.0.1

Re: Codebox theme

Posted: 15 Nov 2018, 01:27
by nnnik
It seems to work correctly in chrome - except for the fact it starts expanded.

Re: Codebox theme

Posted: 15 Nov 2018, 02:24
by joedf
@TAC109 I have not touched the prosilver theme at all. I can update this. Clicking on a command was never intended to be added by me. I could try to implement something, but that was a custom feature. I am not sure what was done to achieve that, possibly some php and modifying geshi... but geshi is not working super well right now.
@hoppfrosch @nnnik Yes, I have noticed this... :/
The expand is also broken for gists...

Re: Codebox theme

Posted: 15 Nov 2018, 20:37
by kczx3
Loving the Monokai theme! Though I would have picked some different colors for some things

Re: Codebox theme

Posted: 17 Nov 2018, 06:29
by Helgef
Thank you very much for your efforts joedf.
Would it be possible to remove the blue border on the left side of the code box and move the zero indentation level more to the left, about where the blue line starts now perhaps.
Something like this,
codebox.png
codebox.png (5.22 KiB) Viewed 2881 times
where the bottom most code box is my suggestion, and the top most is what I see now. The problem with the current one is that code gets very far right on my cellular phone.

I use simplicity theme if that matters.

Cheers.

Re: Codebox theme

Posted: 17 Nov 2018, 11:20
by nnnik
There might be a better different theme for mobile phones.

Re: Codebox theme

Posted: 17 Nov 2018, 14:05
by iseahound
I liked the dark theme, how do I get it back?

Re: Codebox theme

Posted: 17 Nov 2018, 18:00
by joedf
:|

The dark theme is on digi. the light theme is on simplicity.
I don't ill be making a switcher, we have other priority fixes... Really hoping tank replies back soon... :(

for the blue border, I will have to apply the following CSS when I get home (no proper access right now):

Code: Select all

pre[class*="language-"] > code {
    border: 0 !important;
    box-shadow: none !important;
}

Re: Codebox theme

Posted: 18 Nov 2018, 21:22
by joedf
Expand/Collapse should be fixed now.
Also, whenever cloudflare refreshes for you, the blue border should be removed now.

Re: Codebox theme

Posted: 20 Nov 2018, 01:05
by joedf
updated prosilver.

Re: Codebox theme

Posted: 20 Nov 2018, 03:51
by TAC109
Looks good! Thanks.

Re: Codebox theme

Posted: 21 Apr 2019, 18:44
by lexikos
Why are builtins and strings highlighted in the same (green) colour? Weren't builtins blue before?

They should be distinct. At the moment there are some lines of code that are almost entirely bright green (and they aren't comments, which used to be green...).