swagfag wrote: ↑15 Jan 2020, 12:47
im talking in general, not specifically about classes. the silent suppression of errors is an underlying issue plaguing mostly the entirety of v1.
check this out:
why is my MsgBox blank??
Ok, here we have some code to review, versus conjecture about what might be the case. But getting blank from MsgBox,
might be telling you something went wrong, and to try something else. It depends, as a blank MsgBox is not always unwanted or wrong.
And the code could have been constructed differently, as below, to see what each loop was doing (thus you could have blank and data filled MsgBoxes). That it wasn't initially seen to do such, might even be because of the style of indentation chosen made overlooking such easier to do.
Code: Select all
max := 0
Loop Files, C:\Users\xxxx\projects\*, D
{
MsgBox % max(max, A_LoopFileName)
}
But anyway, a solution was found, because the programmer was looking for a type of result and constructed his code accordingly. After all,
code is just instructions that programmers are giving, not the program guiding one to what they are suppose to do. Thus...
Code: Select all
max := 0
Loop Files, C:\Users\xxxx\projects\*, D
if A_LoopFileName is integer
max := max(max, A_LoopFileName)
MsgBox % Max
I'm not saying that v2 can not have advantages over v1, but every change is not always beneficial, better, or necessary. I think what the OP might be getting at (though he can clearly speak for himself), is are many of the changes reflective of input and requests from the community. Is average Joe going to be saying, "Yeah, I need or want that!"
Edit- Grammar correction.