Remove Gui.Add("Ctrl", ...) or Gui.AddCtrl(...)?

Discuss the future of the AutoHotkey language

What to do?

Remove Gui.Add("Ctrl", ...)
4
19%
Remove Gui.AddCtrl(...)
15
71%
Keep both
2
10%
 
Total votes: 21
lexikos
Posts: 6962
Joined: 30 Sep 2013, 04:07
GitHub: Lexikos

Remove Gui.Add("Ctrl", ...) or Gui.AddCtrl(...)?

09 Jun 2020, 20:44

fincs wrote:
15 Oct 2019, 19:25
Speaking of which, Gui.Add("Ctrl", ...) vs Gui.AddCtrl(...). One of these definitely has to go, and I'm not sure which.
Looking through a few pages of results for "GuiCreate", neither one seems more commonly used than the other. I'm more inclined to remove AddCtrl, if either.

Code size: According to my measurements (using dumpbin.exe and a script), removing AddCtrl reduces x64 code size by 1120 bytes, while removing Add only gives 264 bytes. The Type property could be removed as well, but saving only another 112 bytes. The difference is probably due to the strings for the method names - Gui.Add, GuiControl.Type and GuiControl.__Class all rely on the same array of strings, so it can't be removed either way. (Side note: GuiControl.Type is redundant; it just removes the "Gui." prefix and gives you the exact string to pass to Gui.Add.)

Future use: Add has more potential for future expansion. For example:
  • myGui.Add(Scintilla, ...), where Scintilla is a class derived from GuiControl (or implements the right methods).
  • myGui.Add(myChildGui, ...) for better integrating nested GUI windows.
  • myGui.Add(hwnd, ...) for windows created by other means, such as CreateWindowEx or an external library.
I'm sure there are other considerations, which I will leave to someone else to bring up.
Helgef
Posts: 4441
Joined: 17 Jul 2016, 01:02
Contact:

Re: Remove Gui.Add("Ctrl", ...) or Gui.AddCtrl(...)?

10 Jun 2020, 01:36

Future use could be added anyways. It could also be myGui.add ctrl.new(), which would go well together with myGui[name] := ctrl.new() (I know name is a property of ctrl).

I always use myGui.addCtrl, I prefer to add, eg, addButton to my syntax highligter rather than add.

Cheers.
iseahound
Posts: 571
Joined: 13 Aug 2016, 21:04
GitHub: iseahound

Re: Remove Gui.Add("Ctrl", ...) or Gui.AddCtrl(...)?

10 Jun 2020, 09:43

Both should be kept, there's really no argument for one over the other.

@lexikos why did the ahk v2 size balloon to 3 MB around a76?
swagfag
Posts: 3879
Joined: 11 Jan 2017, 17:59

Re: Remove Gui.Add("Ctrl", ...) or Gui.AddCtrl(...)?

10 Jun 2020, 11:11

Gui.AddCtrl(...) has the benefit of providing linters/intellisense/highlighters(as helgef says) with more information
i use Gui.Add("Ctrl", ...) for mostly dumb reasons
  • its what is used throughout the documentation
  • i dont care enough about the highlighter sometimes erroneously painting the occasional .Add() method
  • Gui.AddCtrl('', 'Text') would bug me if i had to create controls with default options. rather than switching to Gui.Add("Ctrl", ...) for those particular instances, i just use Gui.Add("Ctrl", ...) all throughout
i dont care if either got removed. i wouldnt care if both were removed either. i dont think both should be kept, though. they pretty much do the same thing exactly, so why keep both around?
@Helgef what would it mean to:

Code: Select all

MyBtn1 := Button.New('x0 y0', 'MyButton1')
MyGui.Add(MyBtn1)
MyGui.Add(MyBtn1)
MyOtherGui.Add(MyBtn1)
when is the button created? when u call .New()? when it is attached to a gui? what is its Hwnd? can u attach it only once? do the calls that follow throw or do they clone the control?
@iseahound if ure talking about the zip, it simply includes more stuff(x86/x64 exes, docs, bins)
Helgef
Posts: 4441
Joined: 17 Jul 2016, 01:02
Contact:

Re: Remove Gui.Add("Ctrl", ...) or Gui.AddCtrl(...)?

10 Jun 2020, 11:21

@swagfag, good questions, maybe it isn't a good idea. I don't know if the actual control could be created without the gui, but the object could ofc. If there is no control .hwnd would throw. Clone/throw, both possible I suppose.

Cheers.
lexikos
Posts: 6962
Joined: 30 Sep 2013, 04:07
GitHub: Lexikos

Re: Remove Gui.Add("Ctrl", ...) or Gui.AddCtrl(...)?

10 Jun 2020, 16:59

I think the standard control window classes can be created separately and then inserted into a window using SetParent, however:
  • The control's ID depends on how many controls were already in the GUI, as it has to be unique. I'm not sure whether the ID can be changed after creation - there's a GetDlgCtrlID function but no SetDlgCtrlID.
  • The style, position and other options may be affected by the GUI. For instance, positioning is affected by DPIScale and in some cases the font. (The desired/unscaled position is not stored; there's only the Win32 window's actual position.)
  • The control's font is set based on the GUI's current font, but that's done after creation and could be done by Add either way.
Being heavily OOP, .NET uses an approach where the Control is constructed before adding it to the Window. However, the native Win32 window is not created immediately, and I assume most developers use the form designer anyway.
Helgef
Posts: 4441
Joined: 17 Jul 2016, 01:02
Contact:

Re: Remove Gui.Add("Ctrl", ...) or Gui.AddCtrl(...)?

10 Jun 2020, 22:10

Can you make it so one can change one's vote, I clicked the wrong one (ofc :facepalm:)

Sorry.
User avatar
nnnik
Posts: 4466
Joined: 30 Sep 2013, 01:01
Location: Germany

Re: Remove Gui.Add("Ctrl", ...) or Gui.AddCtrl(...)?

11 Jun 2020, 03:52

If we go with add it should be in the form of:
Gui.add(Button(...), position) or similar.
The argument of a string being more convenient doesn't really hold here. We had v1 which was filled with convenient shorthands.
Those turned out to be nonsense though as the language evolved. (e. g. You only ever want to have a string containing a label name in SetTimer etc..)
Objects are even planned in the recent posts by lexikos.
My most favoured syntax would be:
Gui.add(Gui.Button(...), position)
In this setup the Gui takes up both the role of a container and factory for the controls. Meaning that by simply swapping around gui we can get totally different types of GUIs (e. g. Standard Windows Controls vs. ActiveX IE window.)
Recommends AHK Studio
Helgef
Posts: 4441
Joined: 17 Jul 2016, 01:02
Contact:

Re: Remove Gui.Add("Ctrl", ...) or Gui.AddCtrl(...)?

14 Jun 2020, 01:59

lexikos wrote: it could be more general: res := obj {p1: v1, p2: v2} -> res := (obj.p1 := v1, obj.p2 := v2, obj).
src
obj {...} looks like concatenation. A natural response to the concatenation of two objects is to create a new one. It could call obj1.__concat(obj2). Then with,

Code: Select all

Object.__concat(right) {
	new := this.new()	; Object.Protototype.__concat would do this.clone()
	for n, v in right.ownprops()
		new.%n% := v
	return new
}
this would be the default response for any class object. So for this topic, it is relevant as aGui.add CtrlClass {...}. Which is generally useful and could reduce the need for option parsing. It also naturally permits CtrlClass DefaultOpts ExtraOpts.

I think this now overlaps with the other topic :arrow: GuiCreate and Gui.Add parameter order.

Cheers.

I still can't change my vote.
lexikos
Posts: 6962
Joined: 30 Sep 2013, 04:07
GitHub: Lexikos

Re: Remove Gui.Add("Ctrl", ...) or Gui.AddCtrl(...)?

14 Jun 2020, 03:00

Helgef wrote:
14 Jun 2020, 01:59
I still can't change my vote.
Looks like I forgot to enable the option on this topic. It should be enabled now.
Helgef
Posts: 4441
Joined: 17 Jul 2016, 01:02
Contact:

Re: Remove Gui.Add("Ctrl", ...) or Gui.AddCtrl(...)?

14 Jun 2020, 03:07

Thanks, I wanted to keep addCtrl, so ofc I click on addCtrl, not realising it says remove addCtrl, typical helgef error :facepalm:.
User avatar
jNizM
Posts: 2639
Joined: 30 Sep 2013, 01:33
GitHub: jNizM
Contact:

Re: Remove Gui.Add("Ctrl", ...) or Gui.AddCtrl(...)?

15 Jun 2020, 08:07

In short: I prefer Gui.Add("Control", ...)

Code: Select all

hEdt1 := Gui.Add("Edit", "w400 r5 BackgroundE1BEE7", "Edit 1`nEdit 2`nEdit 3").SetFont("c4A148C")

hEdt2 := Gui.Add("Edit", "w400 r5", "Edit 1`nEdit 2`nEdit 3")
hEdt2.SetFont("c0000FF")
hEdt2.Opt("Background00FFFF")
[AHK] 1.1.32.00 x64 Unicode | [WIN] 10 Pro (Version 2004) x64 | [GitHub] Profile
Donations are appreciated if I could help you
HotKeyIt
Posts: 2133
Joined: 29 Sep 2013, 18:35
Contact:

Re: Remove Gui.Add("Ctrl", ...) or Gui.AddCtrl(...)?

15 Jun 2020, 14:08

Helgef wrote:
14 Jun 2020, 03:07
Thanks, I wanted to keep addCtrl, so ofc I click on addCtrl, not realising it says remove addCtrl, typical helgef error :facepalm:.
Same happened to me :)
just me
Posts: 7144
Joined: 02 Oct 2013, 08:51
Location: Germany

Re: Remove Gui.Add("Ctrl", ...) or Gui.AddCtrl(...)?

01 Jul 2020, 11:03

Remove Gui.AddCtrl(...).
User avatar
vvhitevvizard
Posts: 401
Joined: 25 Nov 2018, 10:15
Location: Russia

Re: Remove Gui.Add("Ctrl", ...) or Gui.AddCtrl(...)?

30 Jul 2020, 11:17

nnnik wrote:
11 Jun 2020, 03:52
My most favoured syntax would be:
Gui.add(Gui.Button(...), position)
Helgef wrote:
10 Jun 2020, 01:36
It could also be myGui.add ctrl.new()
I like these :thumbup:

PS: I voted for Gui.AddCtrl(...) removal. Short variant is preferable, it is better for possible extensions to have additional prefixes, gui.add() used way too frequently.
"keep both" option makes no sense completely. ;)
Last edited by vvhitevvizard on 30 Jul 2020, 11:30, edited 2 times in total.
Helgef
Posts: 4441
Joined: 17 Jul 2016, 01:02
Contact:

Re: Remove Gui.Add("Ctrl", ...) or Gui.AddCtrl(...)?

30 Jul 2020, 11:28

I voted for Gui.AddCtrl(...) removal. Short variant is preferable
In my opinion, addCtrl is shorter than add 'Ctrl' :angel:.
Spoiler
Cheers.
User avatar
vvhitevvizard
Posts: 401
Joined: 25 Nov 2018, 10:15
Location: Russia

Re: Remove Gui.Add("Ctrl", ...) or Gui.AddCtrl(...)?

30 Jul 2020, 11:30

Helgef wrote:
30 Jul 2020, 11:28
In my opinion, addCtrl is shorter than add 'Ctrl' :angel:.
the latter is more suitable to build controls programmatically. I, for one, would like to have all the .add method's string parameters to be controlled via separate method calls, in addition to the existing syntax. gc.bgcolor(), gc.fontfamily(), gc.fontstyle(), etc.

Return to “AutoHotkey v2 Development”

Who is online

Users browsing this forum: vvhitevvizard and 4 guests