Code: Select all
EPG_files_location := "D:\TV\Recording Service\EPG Info-Log Files"
Recording_database_backup_location_1 := "D:\AVI_VOB_BLU-RAY_AC3-tools\TV-tools\EPG Info-Log Files Backup"
FileCopy, %EPG_files_location%\*.*, %Recording_database_backup_location_1%\, 0 ;Backup of database
Yes the folder exists. Out of 100 copy sessions maybe 1 fails and it's then the copies ends up in the root directory. The size of each file is small (1kb), but the database files are quite many..at least 6000 in source folder and 11000 in destination folder. The Filecopy command resides in a file-loop yes.joedf wrote:Does the folder exist? How big are the files? Have you tried a file-loop?
Hmm, XCOPY isn't a AHK command. I suppose you mean calling xcopy via comspec?joedf wrote:Hmm ok, I see I will investigate soon... Maybe if you tried 'XCOPY'?
Well, here's the twist...the file-loop gets executed from a service application. The service account have limited permissions if comparing to the ordinary desktop account, so I can't call the shellfileoperation function which is using visible UI. That would mean script will stall. This fact can also have bearing on the topic issue. Only can't work out why the majority of the copy sessions goes well and a few goes bad.Morpheus wrote:You could try Skan's shellfileoperation()
http://www.autohotkey.com/forum/viewtop ... 249#133249
Ok, added some errorlogging and i get an error 80 every time using the Filecopy file-loop even when filecopy works and files arrives to the correct destination folder. Error 80 means:joedf wrote:Hmm ok, add some error logging in your script, so that when it fails,
Log Errorlevel, A_LastError, etc. And thé command that the command that failed.. So that we may investigate further...
Dont understand the error. All sourcefiles already exists in the destination folder, except the ones dropped onto script (the ones that should be copied). The 0 paramter just tells FileCopy to not overwrite already existing files.ERROR_FILE_EXISTS
80 (0x50)
The file exists.
Code: Select all
EPG_files_location := "D:\TV\Recording Service\EPG Info-Log Files"
Recording_database_backup_location_1 := "D:\AVI_VOB_BLU-RAY_AC3-tools\TV-tools\EPG Info-Log Files Backup"
PropCopy_location := "D:\AVI_VOB_BLU-RAY_AC3-tools\TV-tools\DVBViewer\PropCopy_1_2_3\PropCopy.exe"
Loop %0% ; For each parameter (or file dropped onto a script):
{
Givenpath := %A_Index% ; Fetch the contents of the variable whose name is contained in A_Index.
Loop %GivenPath%, 1
{
Params := A_LoopFileLongPath
PutItToTheSlaughter .= """" A_LoopFileLongPath """ "
}
;msgbox % Params
;msgbox % PutItToTheSlaughter
AddToBOF(RS_recording_folder . "\hiberscript_files.log", a_yyyy "-" a_mm "-" a_dd " " a_hour ":" a_min ":" a_sec " - " . Params . "`r`n")
SplitPath, Params, OutFileName, OutDir,, OutNameNoExt
FileCopy, %OutDir%\%OutNameNoExt%.log, %EPG_files_location%\ ;RS logfile will be copied to backupfolder
FileMove, %OutDir%\%OutNameNoExt%.txt, %EPG_files_location%\ ;EPG information file will be moved to a subfolder
Filemove, %OutDir%\%OutNameNoExt%.log, %EPG_files_location%\%OutNameNoExt%.ts ;RS Log file will be moved and renamed to .ts extension
RunWait, %PropCopy_location% "%RS_recording_folder%\%OutNameNoExt%.ts" "%EPG_files_location%\%OutNameNoExt%.ts" ;Metadata/Fileinfo copy
FileCopy, %EPG_files_location%\%OutNameNoExt%.*, %Recording_database_backup_location_1%\, 0 ;Backup of database ;>>>>>>>>>>> HERE IT SOMETIMES GOES WRONG
refresh_recDb := URLToVar(Recording_Service_API_URL . "/tasks.html?task=RefreshDB&aktion=tasks") ;Refresh Recording Service Database
}Code: Select all
#NoEnv
EPG_files_location := "D:\TV\Recording Service\EPG Info-Log Files"
Recording_database_backup_location_1 := "D:\AVI_VOB_BLU-RAY_AC3-tools\TV-tools\EPG Info-Log Files Backup"
PropCopy_location := "D:\AVI_VOB_BLU-RAY_AC3-tools\TV-tools\DVBViewer\PropCopy_1_2_3\PropCopy.exe"
Loop %0% ; For each parameter (or file dropped onto a script):
{
Givenpath := %A_Index% ; Fetch the contents of the variable whose name is contained in A_Index.
Loop %GivenPath%, 1
{
Params := A_LoopFileLongPath
PutItToTheSlaughter .= """" A_LoopFileLongPath """ "
}
;msgbox % Params
;msgbox % PutItToTheSlaughter
AddToBOF(RS_recording_folder . "\hiberscript_files.log", a_yyyy "-" a_mm "-" a_dd " " a_hour ":" a_min ":" a_sec " - " . Params . "`r`n")
SplitPath, Params, OutFileName, OutDir,, OutNameNoExt
FileCopy, %OutDir%\%OutNameNoExt%.log, %EPG_files_location%\ ;RS logfile will be copied to backupfolder
FileMove, %OutDir%\%OutNameNoExt%.txt, %EPG_files_location%\ ;EPG information file will be moved to a subfolder
Filemove, %OutDir%\%OutNameNoExt%.log, %EPG_files_location%\%OutNameNoExt%.ts ;RS Log file will be moved and renamed to .ts extension
RunWait, %PropCopy_location% "%RS_recording_folder%\%OutNameNoExt%.ts" "%EPG_files_location%\%OutNameNoExt%.ts" ;Metadata/Fileinfo copy
Loop, %EPG_files_location%\%OutNameNoExt%.*
FileCopy, %A_LoopFileLongPath%, %Recording_database_backup_location_1%\%A_LoopFileName%, 0 ; Backup of database
refresh_recDb := URLToVar(Recording_Service_API_URL . "/tasks.html?task=RefreshDB&aktion=tasks") ;Refresh Recording Service Database
}
This issue has bugged me for years and i still havent the slightest idea what may cause it. Often I happen to discover it when working in the explorer and by then it could have gone days since the issue occcured and i have of course no recollection of the circumstances around the error. Im thinking of adding some kind of visible alert if/when errorlevel >= 1. However there is a problem. The script is launched in the service account and the MS permission limitations prevents me from using any kind of visible userinterface such as msgboxes, that would stall the afterrecording task that launches this script. I was thinking maybe it could work if script triggers some task in the windows scheduler. I definitely have to look up if that is a viable way to go. Code: Select all
Loop, %EPG_files_location%\%OutNameNoExt%.* {
FileCopy, %A_LoopFileLongPath%, %Recording_database_backup_location_1%\%A_LoopFileName%, 0 ; Backup of database
AddToBOF(A_ScriptDir . "\DatabaseCopyError.log", a_yyyy "-" a_mm "-" a_dd " " a_hour ":" a_min ":" a_sec " - " . A_LastError . "`r`n")
}
All those 6000+ files was wrongly copied to root. Hmm...I guess it's time to test out XCOPY and Skan's shellfileoperation() next.Seems SKANs version doesnt support unicode. XCOPY and Robocopy seems to be ancient and I wont even try em to handle the unicode stars. Wow, I found this very promising function which I think is made by the great just meMorpheus wrote:You could try Skan's shellfileoperation()
http://www.autohotkey.com/forum/viewtop ... 249#133249
Im positive this is the solution to my problems 
It has been working nicely thus far.Code: Select all
Loop, %EPG_files_location%\%OutNameNoExt%.* {
FilesToCopy := [A_LoopFileLongPath] ;ShellFileOperation SourceArray
SHFileOperation(FilesToCopy, Recording_database_backup_location_1, 2) ;ShellFileOperation
}
; ==================================================================================================================================
; Copy or move files and folders using the SHFileOperation() function.
; SHFileOperation -> msdn.microsoft.com/en-us/library/bb762164(v=vs.85).aspx
; Parameters:
; SourcesArray - Array of fully qualified source pathes.
; TargetPath - Fully qualified path of the destination folder.
; Operation - FO_MOVE = 1, FO_COPY = 2, other operations are not supported.
; HWND - A handle to the window which will own the dialog.
; Flags - Any combination of the FOF_ flags -> msdn.microsoft.com/en-us/library/bb759795(v=vs.85).aspx
; Default: FOF_NOCONFIRMMKDIR = 0x0200.
; Return values:
; Returns 1 (True) if successful; otherwise 0 (False).
; ==================================================================================================================================
SHFileOperation(SourcesArray, TargetPath, Operation, HWND := 0, Flags := 0x0200) {
Static TCS := A_IsUnicode ? 2 : 1 ; size of a TCHAR
If Operation Not In 1,2
Return False
; Count files and total string length
TotalLength := 0
Files := []
For Each, FilePath In SourcesArray {
If (Length := StrLen(FilePath))
Files.Push({Path: FilePath, Len: Length + 1})
TotalLength += Length
}
FileCount := Files.Length()
If !(FileCount && TotalLength)
Return
; Store the source pathes in Sources (the string must be double-null terminated)
VarSetCapacity(Sources, (TotalLength + FileCount + 1) * TCS, 0)
Offset := 0
For Each, File In Files
Offset += StrPut(File.Path, &Sources + Offset, File.Len) * TCS
; Store the target path in Target (the string must be double-null terminated)
TargetLen := StrLen(TargetPath) + 2
VarSetCapacity(Target, TargetLen * TCS, 0)
Target := TargetPath
; Create and fill the SHFILEOPSTRUCT
SHFOSLen := A_PtrSize * (A_PtrSize = 8 ? 7 : 8)
VarSetCapacity(SHFOS, SHFOSLen, 0) ; SHFILEOPSTRUCT
NumPut(HWND, SHFOS, 0, "UPtr") ; hwnd
NumPut(Operation, SHFOS, A_PtrSize, "UInt") ; wFunc
NumPut(&Sources, SHFOS, A_PtrSize * 2, "UPtr") ; pFrom
NumPut(&Target, SHFOS, A_PtrSize * 3, "UPtr") ; pTo
NumPut(Flags, SHFOS, A_PtrSize * 4, "UInt") ; fFlags
If (A_IsUnicode)
Return !DllCall("Shell32.dll\SHFileOperationW", "Ptr", &SHFOS, "Int")
Else
Return !DllCall("Shell32.dll\SHFileOperationA", "Ptr", &SHFOS, "Int")
}