says unneeded { and } but idk why? Topic is solved

[wryyymuda]

this is the code, right now i'm trying to make a file that reads a text doc and generates a random line from it but i ran into an unexpected error, at lines 8 and 11 it says } is unexpected but i'm extremely confused by this. can anyone help?

Code: Select all

#singleinstance, force

inputbox, file, input, which .txt file 
+.::
if ( file > 0 ) {
	Loop, Read, %file% {
		lines = %A_Index% 
		}
		msgbox, %lines%
		return
	}
else if ( file = file) {
	msgbox, no file selected!
	ExitApp
	}

[gregster]

The one-true-brace style (block's opening brace on the same line as the block's controlling statement rather than underneath on a line by itself) is only allowed for normal loops:
https://autohotkey.com/docs/commands/Block.htm#otb
https://autohotkey.com/docs/commands/Loop.htm#Remarks
this means, you will have to use:

Code: Select all

Loop, Read, %file% 
{

[wryyymuda]

The one-true-brace style (block's opening brace on the same line as the block's controlling statement rather than underneath on a line by itself) is only allowed for normal loops:
https://autohotkey.com/docs/commands/Block.htm#otb
https://autohotkey.com/docs/commands/Loop.htm#Remarks
this means, use:

Code: Select all

Loop, Read, %file% 
{

so it should be like

Code: Select all

loop, read, %file%
{
	lines= %A_index%
}
msgbox, lines in file = %lines%

thats how it works?

[gregster]

Yes.

[wryyymuda]

this hurts

[wryyymuda]

full code below, just reads a random line from txt file.

Code: Select all

#singleinstance, force
inputbox, file, input txt, file to read (press < to activate)
+.::
	if ( file > 0 ) 
	{
	Loop, Read, %file% 
		{
			lines = %A_Index% 
		}
	random, rngline , 1 , %lines%
	filereadline , text, %file%, %rngline%
	msgbox, %text%
	}
	else if ( 1 = 1) 
	{
		msgbox, no file selected!
		ExitApp
	}
Return

[gregster]

Just to be clear, the problem was only in the one Loop, Read line.
The brackets in the if-lines should have been ok, because you used expression style if (with parentheses: () )... but with brackets on its own lines you should be safe, if you are in doubt.

btw, else if ( 1 = 1) is redundant... because the if-test is always true here. Thus, you can just use else.

Also, a (text) file could be legally named 0 (without extension) - then, your if-statement might miss this special case. Better use if ( file != "" ) or something like this.