Is there any better way to monitor memory address?

[kyuuuri]

My software monitors 20 memory addresses and reacts when none of them contains any of the pre-defined numbers, right now I'm using something like this:

Code: Select all

answer1 := 1
answer2 := 2
answer3 := 3
values := []
Loop
{
	Loop, 20
		values[a_index] := Readmemory(Addresses[a_index])
	Loop, 3
	{
		temp:=0
		Loop, 20
		{
			if (values[a_index]<>answer%a_index%)
				temp++
		}
		if temp=20
			gosub react
	}
	sleep, 10
}

ReadMemory(MADDRESS)
{
	global
	local MVALUE
	VarSetCapacity(MVALUE,4,0)
	DllCall("ReadProcessMemory", "Uint", ProcessHandle, "Uint", MADDRESS, "str" , MVALUE, "Uint", 4, "Uint*", 0)
	return *(&MVALUE+3)<<24 | *(&MVALUE+2)<<16 | *(&MVALUE+1)<<8 | *(&MVALUE)
}

Is there a better/faster/less consuming way to achieve this? Is this the correct way to do it?

Thanks in advance!

@edit: fixed some typos.

[YoucefHam]

use this

Code: Select all

ReadMemory(MADDRESS,PROGRAM)
{
   Process, wait, %PROGRAM%, 0.5
   pid = %ErrorLevel%
   if pid = 0
   {
      MsgBox The specified process could not be found.
      return
   }

   VarSetCapacity(MVALUE,4,0)
   ProcessHandle := DllCall("OpenProcess", "Int", 24, "Char", 0, "UInt", pid, "Uint")
   DllCall("ReadProcessMemory","UInt",ProcessHandle,"Uint",MADDRESS,"Str",MVALUE,"UInt",4,"str P",0)

   Loop 4
   result += *(&MVALUE + A_Index-1) << 8*(A_Index-1)

   DllCall("CloseHandle", "int", ProcessHandle)
   
   return, result 
}

[kyuuuri]

use this

Code: Select all

ReadMemory(MADDRESS,PROGRAM)
{
   Process, wait, %PROGRAM%, 0.5
   pid = %ErrorLevel%
   if pid = 0
   {
      MsgBox The specified process could not be found.
      return
   }

   VarSetCapacity(MVALUE,4,0)
   ProcessHandle := DllCall("OpenProcess", "Int", 24, "Char", 0, "UInt", pid, "Uint")
   DllCall("ReadProcessMemory","UInt",ProcessHandle,"Uint",MADDRESS,"Str",MVALUE,"UInt",4,"str P",0)

   Loop 4
   result += *(&MVALUE + A_Index-1) << 8*(A_Index-1)

   DllCall("CloseHandle", "int", ProcessHandle)
   
   return, result 
}

Why use that instead of what I used? Is it faster, better? Also why would I close the handle if I'm always reading memory? Isn't this way slower?

[YoucefHam]

you need to find the static memory address of that value and use it.

Code: Select all

Value := ReadMemory("0x01B91E58","calc.exe")

[kyuuuri]

you need to find the static memory address of that value and use it.

Code: Select all

Value := ReadMemory("0x01B91E58","calc.exe")

Oh okay, so you are a bot or you don't know how to read maybe.
Please, Can u read what I wrote? If not then gtfo, thank you!
Didn't want to be rude but I hate people like him.

[YoucefHam]

xD

sorry, your software have a GUI?

[kyuuuri]

Please! don't post again, thank you!

[YoucefHam]

ok!
Just wanted to help and learn with you. Sorry.

[kyuuuri]

ok!
Just wanted to help and learn with you. Sorry.

I'm sorry for being rude but you didn't even read what I wrote, that's disrespectful.
Thanks anyway, but don't post anymore.