Need Help Writing filename

[Legion26]

Good day

I don't have a lot of coding experience and I placed this together with some googling and it was working fine but now I would like to write my var number in front of the file name.

I added line 22 and line 31 and it doesn't want to write the var name in front of the filename can anyone tell me why it's not working and maybe show me how I can get it working.

fileName := var + "_" + fileName

Spoiler

Code: Select all

var := 32395
Loop,1
{

dlink := "https d-08.winudf.com /custom/com.apkpure.aegon-3172011.apk?_fn=QVBLUHVyZV92My4xNy4yMF9hcGtwdXJlLmNvbS5hcGs&_p=Y29tLmFwa3B1cmUuYWVnb24&am=SDxJezZ7D6qtwMMywxjptQ&arg=apkpure%3A%2F%2Fcampaign%2F%3Futm_source%3Dapkpure%26utm_medium%3Dhttps%253A%252F%252Fwww.google.com%252F&at=1622108893&k=dd047fdb702c48e4f361b08825d020ae60b0bc5f&uu=http%3A%2F%2F172.16.59.1%2Fcustom%2Fcom.apkpure.aegon-3172011.apk%3Fk%3De6b44c8c4ea8926b764cd11a4089aeae60b0bc5f"  Broken Link for safety
Download(dlink)
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
Download(url) {
    If (!InStr(url,"://"))
        url := "http://" . url
    WebRequest := ComObjCreate("WinHttp.WinHttpRequest.5.1")
    WebRequest.Open("GET", url)
    WebRequest.Send()
    
    ComObjError(false)
    cdHeader := WebRequest.GetResponseHeader("Content-Disposition")
    ComObjError(true)
    
    If (cdHeader) {
        RegexMatch(cdHeader,"filename=""([^""]+)""", match)
        fileName := match1
	fileName := var + "_" + fileName
	        
        ADODBObj := ComObjCreate("ADODB.Stream")
        ADODBObj.Type := 1
        ADODBObj.Open()
        ADODBObj.Write(WebRequest.ResponseBody)
        ADODBObj.SaveToFile(fileName, 2)
        ADODBObj.Close()
    } Else {
	fileName := var + "_" + fileName
        SplitPath, url, fileName
        UrlDownloadToFile, %url%, %fileName%
    }
}
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
var := var + 1
}

[gregster]

+ is not used as a concatenation operator in AHK.

In AHK, in expression mode, you can do either of these:

Code: Select all

fileName := var "_" fileName
; or 
fileName := var . "_" . fileName

See https://www.autohotkey.com/docs/Variables.htm#concat for more details.

[Legion26]

+ is not used as a concatenation operator in AHK.

In AHK, in expression mode, you can do either of these:

Code: Select all

fileName := var "_" fileName
; or 
fileName := var . "_" . fileName

See https://www.autohotkey.com/docs/Variables.htm#concat for more details.

I tried this but it still doesn't write the var number in front of my filename

[gregster]

Yes, it does:

Code: Select all

var := 32395
filename := "helloworld.txt"
fileName := var "_" fileName
msgbox % filename

var++
filename := "anotherfile.txt" 
fileName := var . "_" . fileName
msgbox % filename

But it looks like you are overwriting the result with the following line SplitPath, url, fileName, at least in your else-branch... perhaps you want to switch these lines?

[Legion26]

Yes, it does:

Code: Select all

var := 32395
filename := "helloworld.txt"
fileName := var "_" fileName
msgbox % filename

var++
filename := "anotherfile.txt" 
fileName := var . "_" . fileName
msgbox % filename

But it looks like you are overwriting the result with the following line SplitPath, url, fileName, at least in your else-branch... perhaps you want to switch these lines?

I figured out what was wrong with the code the var was cleared when I entered the if function I just made the var a Global and it all works now