How to make AutoHotkey.Interop call a C# function right?

[ntnvsl]

What's wrong with this code? It actually works, but crashes fatally after several keypresses.

Code: Select all

using System;
using System.Linq;
using System.Windows;
using System.Diagnostics;
using System.Runtime.InteropServices;
using FlaUI.UIA3;
using Application = FlaUI.Core.Application;
using AutoHotkey.Interop;

namespace random
{
  public partial class MainWindow : Window
  {
    delegate void Test();

    public MainWindow()
    {
      var program = Process.GetProcessesByName("notepad").First();
      var app = Application.Attach(program.Id);
      var mainWindow = app.GetMainWindow(new UIA3Automation());

      var ahk = AutoHotkeyEngine.Instance;

      Test rand = () => ahk.ExecRaw($"send {(new Random()).Next(100, 200)}");

      ahk.ExecRaw("#IfWinActive ahk_exe notepad.exe");
      ahk.ExecRaw($"RCtrl::DllCall({Marshal.GetFunctionPointerForDelegate(rand)})");

      InitializeComponent();
    }
  }
}

Untitled.png (5.09 KiB) Viewed 3447 times

[swagfag]

is ur C# app 32bit or 64bit?

[ntnvsl]

is ur C# app 32bit or 64bit?

32bit

[HotKeyIt]

Do you have any working Example? I assume you have to start a thread first (ahktextdll).
Probably something like this: https://csharp.hotexamples.com/de/examples/-/AutoHotkey.Interop.AutoHotkeyEngine/-/php-autohotkey.interop.autohotkeyengine-class-examples.html

[swagfag]

it does start a thread https://github.com/amazing-andrew/AutoHotkey.Interop/blob/master/src/AutoHotkey.Interop/AutoHotkeyEngine.cs#L17-L24
this uses a very old binary 1.1.13
it could be a problem with the C# wrapper, or there could be a bug in that ahk version or it could be something else
i suggest trying to load the dll(LoadLibrary, GetProcAddress) and calling the functions manually without the wrapper to see if it crashes. if it does, its probably an ahk bug - try updating to whatever the currently available latest AHK_H v1 version is

[burque505]

@ntnvsl, the original code on GitHub for AutoHotkey.Interop is missing a reference to the .ahkready method. That'll kill you. I've been there. You can recompile the DLL and get around this. Here's the modified code for AutoHotkeyEngine.cs:

Spoiler

Code: Select all

using AutoHotkey.Interop.Util;
using System;
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Runtime.InteropServices;
using System.Text;
using System.Threading.Tasks;

namespace AutoHotkey.Interop
{
    /// <summary>
    /// This class expects an AutoHotkey.dll to be available on the machine. (UNICODE) version.
    /// </summary>
    public class AutoHotkeyEngine
    {
        public static AutoHotkeyEngine Instance { get { return lazyInstance.Value; } }
        private static Lazy<AutoHotkeyEngine> lazyInstance =
            new Lazy<AutoHotkeyEngine>(() => new AutoHotkeyEngine());

        private AutoHotkeyEngine() {
            Util.AutoHotkeyDllLoader.EnsureDllIsLoaded();
            AutoHotkeyDll.ahktextdll("", "", "");
        }

        /// <summary>
        /// Gets the value for a varible or an empty string if the variable does not exist.
        /// </summary>
        /// <param name="variableName">Name of the variable.</param>
        /// <returns>Returns the value of the variable, or an empty string if the variable does not exist.</returns>
        public string GetVar(string variableName)
        {
                var p = AutoHotkeyDll.ahkgetvar(variableName, 0);
                return Marshal.PtrToStringUni(p);
        }

        /// <summary>
        /// Sets the value of a variable.
        /// </summary>
        /// <param name="variableName">Name of the variable.</param>
        /// <param name="value">The value to set.</param>
        public void SetVar(string variableName, string value)
        {
                if (value == null)
                    value = "";

                AutoHotkeyDll.ahkassign(variableName, value);
        }

        /// <summary>
        /// Evaulates an expression or function and returns the results
        /// </summary>
        /// <param name="code">The code to execute</param>
        /// <returns>Returns the result of an expression</returns>
        public string Eval(string code)
        {
                var codeToRun = "A__EVAL:=" + code;
                AutoHotkeyDll.ahkExec(codeToRun);
                return GetVar("A__EVAL");
        }

        /// <summary>
        /// Loads a file into the running script
        /// </summary>
        /// <param name="filePath">The filepath of the script</param>
        public void LoadFile(string filePath) {
            var absolute_file_path = Path.GetFullPath(filePath);

                //AutoHotkeyDll.addFile(absolute_file_path, 1, 1);
                string script = File.ReadAllText(filePath);
                this.LoadScript(script);
        }

        public void LoadScript(string scriptText) {
                AutoHotkeyDll.addScript(scriptText, AutoHotkeyDll.Execute.RunWait);
        }
        /// <summary>
        /// Executes raw ahk code.
        /// </summary>
        /// <param name="code">The code to execute</param>
        public void ExecRaw(string code)
        {
                AutoHotkeyDll.ahkExec(code);
        }

        /// <summary>
        /// Terminates the running scripts
        /// </summary>
        public void Terminate()
        {
                AutoHotkeyDll.ahkTerminate(1000);
        }

        public void Reset() {
                Terminate();
                AutoHotkeyDll.ahkReload();
                AutoHotkeyDll.ahktextdll("", "", "");
        }

        /// <summary>
        /// Suspends the scripts
        /// </summary>
        public void Suspend()
        {
                ExecRaw("Suspend, On");
        }

        /// <summary>
        /// Unsuspends the scripts
        /// </summary>
        public void UnSuspend()
        {
                ExecRaw("Suspend, Off");
        }

        /// <summary>
        /// Executes an already defined function.
        /// </summary>
        /// <param name="functionName">The name of the function to execute.</param>
        /// <param name="param1">The 1st parameter</param>
        /// <param name="param2">The 2nd parameter</param>
        /// <param name="param3">The 3rd parameter</param>
        /// <param name="param4">The 4th parameter</param>
        /// <param name="param5">The 5th parameter</param>
        /// <param name="param6">The 6th parameter</param>
        /// <param name="param7">The 7th parameter</param>
        /// <param name="param8">The 8th parameter</param>
        /// <param name="param9">The 9th parameter</param>
        /// <param name="param10">The 10 parameter</param>
        public string ExecFunction(string functionName,
            string param1 = null,
            string param2 = null,
            string param3 = null,
            string param4 = null,
            string param5 = null,
            string param6 = null,
            string param7 = null,
            string param8 = null,
            string param9 = null,
            string param10 = null)
        {
                IntPtr ret = AutoHotkeyDll.ahkFunction(functionName, param1, param2, param3, param4, param5, param6, param7, param8, param9, param10);

                if (ret == IntPtr.Zero)
                    return null;
                else
                    return Marshal.PtrToStringUni(ret);
        }


        /// <summary>
        /// Determines if the function exists.
        /// </summary>
        /// <param name="functionName">Name of the function.</param>
        /// <returns>Returns true if the function exists, otherwise false.</returns>
        public bool FunctionExists(string functionName)
        {
                IntPtr funcptr = AutoHotkeyDll.ahkFindFunc(functionName);
                return funcptr != IntPtr.Zero;
        }

        /// <summary>
        /// Executes a label
        /// </summary>
        /// <param name="labelName">Name of the label.</param>
        public void ExecLabel(string labelName)
        {
                AutoHotkeyDll.ahkLabel(labelName, false);
        }

        /// <summary>
        /// Determines if the label exists.
        /// </summary>
        /// <param name="labelName">Name of the label.</param>
        /// <returns>Returns true if the label exists, otherwise false</returns>
        public bool LabelExists(string labelName)
        {
                IntPtr labelptr = AutoHotkeyDll.ahkFindLabel(labelName);
                return labelptr != IntPtr.Zero;
        }

        /// <summary>
        /// Enables communication between AutoHotkey code and the hosting enviorment.
        /// This module imports an AHK function named SendPipeMessage that you can use
        /// call the specified handler.
        /// </summary>
        /// <param name="sendPipeMessageHandler">The handler that will receive the SendPipesMessage from AHK.</param>
        public void InitalizePipesModule(Func<string, string> sendPipeMessageHandler) {
            Pipes.PipesModuleLoader.LoadPipesModule(sendPipeMessageHandler);
        }
        public bool IsReady()
        {
            if (AutoHotkeyDll.ahkReady() == true)
            {
                return true;
            }
            else
            {
                return false;
            }
        }

    }
}

Once you've done this, and assuming your AutoHotkeyEngine.Instance is named 'AHK', you now have Ahk.IsReady() available. You'll still probably need to get rid of the created AutoHotkeyEngine.Instance when finished or it WILL hang around and crash unpredictably.
My mods to your code (can't test):

Spoiler

Code: Select all

using System;
using System.Linq;
using System.Windows;
using System.Diagnostics;
using System.Runtime.InteropServices;
using System.Threading;
using FlaUI.UIA3;
using Application = FlaUI.Core.Application;
using AutoHotkey.Interop;

namespace random
{
  public partial class MainWindow : Window
  {
    delegate void Test();

    public MainWindow()
    {
      var program = Process.GetProcessesByName("notepad").First();
      var app = Application.Attach(program.Id);
      var mainWindow = app.GetMainWindow(new UIA3Automation());

      var ahk = AutoHotkeyEngine.Instance;

      Test rand = () => ahk.ExecRaw($"send {(new Random()).Next(100, 200)}");

      ahk.ExecRaw("#IfWinActive ahk_exe notepad.exe");
      ahk.ExecRaw($"RCtrl::DllCall({Marshal.GetFunctionPointerForDelegate(rand)})");
      while (ahk.IsReady()==true) {
    		Thread.Sleep(100);
                }
      ahk.Reset();
      // ahk = null; //not sure where this should go, but I have had to experiment with this often. 
      // If you don't get rid of the AutoHotkeyEngine.Instance your program will exhibit unpredictable behavior, such as running for a while
      // just fine and then crashing.
      InitializeComponent();
    }
  }
}

I hope this helps, I know it's like vanishing down a rabbit hole. I've cobbled together plugins for several RPA platforms using AutoHotkey.Interop in one form or another, and I always get bit by where and when I need to call .IsReady(), and by instances of the engine hanging around. (You can also try sharpAHK which exists in various forms on the web. You could also download my mod of it from nuget here to see if that works.)

Hope this is more good than harm
Regards,
burque505