menu setIcon The obtained icon is incorrect

[gekunfei]

[Moderator's note: Topic moved from Bug Reports.]

Menu.setIcon("xx", "C:\WINDOWS\System32\SHELL32.dll", 130, 32)
icon error

Correct icon

Snipaste_2024-05-20_08-44-27.png (16.23 KiB) Viewed 679 times

Correct icon

error icon

Snipaste_2024-05-20_08-41-44.png (19.93 KiB) Viewed 679 times

[Ragnar]

AutoHotkey uses 1-based icon numbers. There's no icon 0. Add 1 to each icon number and you have the icons you want.

[gekunfei]

It's like this, I think this should be emphasized in the help file, which is different from the default icon numbering in Windows

[just me]

IconNumber

Type: Integer

If omitted, it defaults to 1 (the first icon group). Otherwise, specify the number of the icon group to be used in the file. For example, MyMenu.SetIcon(MenuItemName, "Shell32.dll", 2) would use the default icon from the second icon group. If negative, its absolute value is assumed to be the resource ID of an icon within an executable file.

What should be emphasized?

[gekunfei]

Emphasize that the icon obtained by win starts from scratch and requires +1 in ahk

[lexikos]

Windows tends to use IDs, not a sequential index; AutoHotkey uses negative numbers for IDs. I don't recall there being any standard OS-provided GUI or utility that will show you an icon number or ID. It's not the documentation author's place to guess where you might have obtained an icon number and whatever scheme it uses.

I think "it defaults to 1 (the first icon group)" is pretty clear. If you miss that, right at the beginning of the documentation for IconNumber, I don't think emphasis will help. It's not as though the documentation can predict the exact thing you're looking for and point it out for you. There could be any number of things that someone else would have liked emphasised at some point in time, but would only be a distraction at any other time.