Compare 2 files for a match

[Karis]

I spent hours trying to figure out what's wrong... with no succes.

What I'm trying to do:
Make script download 2 text files from 2 websites. Read them both, if there's a match, pop up a message box saying Match.

Code: Select all

UrlDownloadToFile, http://authority.000webhostapp.com/test, key
FileRead, key, key

UrlDownloadToFile, https://wtfismyip.com/text, ip
FileRead, ip, ip

if ip = %key%
{
MsgBox, Match
sleep 200
ExitApp
}
}

[TheDewd]

Very close... I think your issue is using percent signs in your var matching...

Code: Select all

#SingleInstance, Force

Gui, Margin, 10, 10
Gui, Add, Text, w220, Input:
Gui, Add, Edit, y+10 wp r1 vUser
Gui, Add, Button, y+10 wp h20 gBtnSubmit, Submit
Gui, Show, AutoSize, Authorization
return

BtnSubmit:
    Gui, Submit
    UrlDownloadToFile, http://authority.000webhostapp.com/test, key
    UrlDownloadToFile, https://wtfismyip.com/text, ip
    FileRead, key, key
    FileRead, ip, ip

    If (ip = key) {
        MsgBox, Match
        ExitApp
    }
return

[Ovg]

Extra } at the end of the file

[wolf_II]

Try this:

Code: Select all

Gui, Add, Edit, x12 y30 w220 h20 vUser,
Gui, Add, Button, x12 y60 w220 h20 , Submit
Gui, Add, Text, x12 y10 w90 h20 +BackgroundTrans, Input
; Generated using SmartGUI Creator for SciTE
Gui, Show, w256 h93, Authorization
return

ButtonSubmit:
    Gui, Submit

    UrlDownloadToFile, http://authority.000webhostapp.com/test, key
    FileRead, key, key

    UrlDownloadToFile, https://wtfismyip.com/text, ip
    FileRead, ip, ip

    if ip = %key%
    {
        MsgBox, Match
        ExitApp
    }

    else
        MsgBox, no match!`n`n%key%`n%ip%

Return

I hope that helps.

[brutus_skywalker]

Just do a size comparison,as FileSize reads size in bytes unless defined otherwise,it should be very accurate.

Code: Select all

FileGetSize, keySize, key
FileGetSize, ipSize, ip

if ipSize = keySize
  {
 MsgBox Match
  ExitApp
  }

[TheDewd]

Just do a size comparison,as FileSize reads size in bytes unless defined otherwise,it should be very accurate.

This would be the same as counting the characters. If both IP addresses had the same number of characters, it would read as a match even if the IP addresses didn't match. Not very accurate.

[brutus_skywalker]

Just do a size comparison,as FileSize reads size in bytes unless defined otherwise,it should be very accurate.

This would be the same as counting the characters. If both IP addresses had the same number of characters, it would read as a match even if the IP addresses didn't match. Not very accurate.

Ahh,yeah, differences between files would have to be significant my approach to be remotely reliable.
So yeah disregard...

[Karis]

Very close... I think your issue is using percent signs in your var matching...

Code: Select all

#SingleInstance, Force

Gui, Margin, 10, 10
Gui, Add, Text, w220, Input:
Gui, Add, Edit, y+10 wp r1 vUser
Gui, Add, Button, y+10 wp h20 gBtnSubmit, Submit
Gui, Show, AutoSize, Authorization
return

BtnSubmit:
    Gui, Submit
    UrlDownloadToFile, http://authority.000webhostapp.com/test, key
    UrlDownloadToFile, https://wtfismyip.com/text, ip
    FileRead, key, key
    FileRead, ip, ip

    If (ip = key) {
        MsgBox, Match
        ExitApp
    }
return

Didn't work unfortunately.

Gui, Add, Edit, x12 y30 w220 h20 vUser,
Gui, Add, Button, x12 y60 w220 h20 , Submit
Gui, Add, Text, x12 y10 w90 h20 +BackgroundTrans, Input
; Generated using SmartGUI Creator for SciTE
Gui, Show, w256 h93, Authorization
return

ButtonSubmit:
Gui, Submit

UrlDownloadToFile, http://authority.000webhostapp.com/test, key
FileRead, key, key

UrlDownloadToFile, https://wtfismyip.com/text, ip
FileRead, ip, ip

if ip = %key%
{
MsgBox, Match
ExitApp
}

else
MsgBox, no match!`n`n%key%`n%ip%

Return

Gave me a no match. But displayed the exact same IPs.

[wolf_II]

Try this:

Code: Select all

Gui, Add, Edit, x12 y30 w220 h20 vUser,
Gui, Add, Button, x12 y60 w220 h20 , Submit
Gui, Add, Text, x12 y10 w90 h20 +BackgroundTrans, Input
; Generated using SmartGUI Creator for SciTE
Gui, Show, w256 h93, Authorization
return

ButtonSubmit:
    Gui, Submit

    UrlDownloadToFile, http://authority.000webhostapp.com/test, key
    FileRead, key, key

    UrlDownloadToFile, https://wtfismyip.com/text, ip
    FileRead, ip, ip

    if ip = %key%
    {
        MsgBox, Match
        ExitApp
    }

    else {
        Loop, % StrLen(key)
            If (k:=SubStr(key, A_Index, 1)) != (i:=SubStr(ip, A_Index, 1)) {
                p := A_Index
                Break
            }
        }
        MsgBox, no match!`n`n%key%`n%ip%`nmismatch at position %p%`n %k% != %i%
Return

I hope that helps.

[Karis]

Mismatched.

Displayed exact same IPs like before.

[wolf_II]

Try this: (otherwise, please report where the mismatch position was found!)

Code: Select all

Gui, Add, Edit, x12 y30 w220 h20 vUser,
Gui, Add, Button, x12 y60 w220 h20 , Submit
Gui, Add, Text, x12 y10 w90 h20 +BackgroundTrans, Input
; Generated using SmartGUI Creator for SciTE
Gui, Show, w256 h93, Authorization
return

ButtonSubmit:
    Gui, Submit

    UrlDownloadToFile, http://authority.000webhostapp.com/test, key
    FileRead, key, key

    UrlDownloadToFile, https://wtfismyip.com/text, ip
    FileRead, ip, ip

    if Trim(ip) = Trim(key) ; trim whitespace
    {
        MsgBox, Match
        ExitApp
    }
Return

I hope that helps.

[Karis]

Mismatch position was found at 5 != 5 (previous script)

The one you just sent didn't give me anything after submitting.

[Karis]

Alright so it works if I put in the same link for "key" and "ip". Now what I don't understand is why the other link doesn't work, if it downloads the same exact file...

[Karis]

Retrieved the IP using the same website this time instead of wtfismyip. Still does not work. Is this a bug with autohotkey perhaps?


EDIT:
I might have fixed it! Using FileReadLine to read line 1 gave me a match. But I still do not understand why FileRead won't work.
Both downloaded files only have 1 line in them with the IP address. Then why is FileRead having so much trouble with it?

EDIT2:
It looks like it's still not functioning properly... This time whatever I put in shows up as a match.. As you can see the Msgbox when it fails is not displaying the second IP.

EDIT3:
It is not reading the downloaded file from the authority site properly for some reason..

EDIT4:
Used the wrong variable. My bad. It's working now, thank you everyone who helped.

[brutus_skywalker]

final suggestion, instead of comparing strings or files, how about comparing the hashes of the downloaded files,here's a pretty good hashing function:

https://autohotkey.com/board/topic/8586 ... -md5-sha1/