How can I make this MultiPressListener better?

[GollyJer]

My goal was to create a reusable way to handle multiple key presses. This below code works OK but smells and is buggy. Pressing F1, F1, F2 within the listenLength doesn't work correctly.
I feel like there's a better way. Maybe Custom Objects or some other less messy approach?

The goal would be to track keyPresses separately for each handler.
Any insight is appreciated. Thanks!

Code: Select all

#SingleInstance force
#NoEnv 

F1:: ListenForMultiplePresses(func("F1Handler"))
F2:: ListenForMultiplePresses(func("F2Handler"))

ListenForMultiplePresses(pressHandler, listenLength := 400) {
  Global keyPresses
  If ((A_PriorHotkey = A_ThisHotkey) && (keyPresses > 0)) {
    keyPresses += 1
    Return
  }
  keyPresses := 1
  SetTimer, %pressHandler%, %listenLength%
}

F1Handler() {
  Global keyPresses
  If (keyPresses = 1) {
    MsgBox, F1 pressed once.

  } Else If (keyPresses = 2) {
    MsgBox, F1 pressed twice.

  } Else If (keyPresses > 2) {
    MsgBox, F1 pressed twice+.

  }
  SetTimer, F1Handler, Off
  keyPresses := 0
}


F2Handler() {
  Global keyPresses
  If (keyPresses = 1) {
    MsgBox, F2 pressed once.

  } Else If (keyPresses = 2) {
    MsgBox, F2 pressed twice.

  } Else If (keyPresses > 2) {
    MsgBox, F2 pressed twice+.

  }
  SetTimer, F2Handler, Off
  keyPresses := 0
}

[DorisMilbourn]

My advice is ,Use react-key down as a higher-order element or decorator to skip key down occasions to the wrapped aspect, or name techniques directly through particular keys. Appropriate for implementing keyboard navigation or other shortcuts.

[Delta Pythagorean]

Using Arrays, you can allow "smaller" and easier to manipulate messages

Code: Select all

#SingleInstance force
#NoEnv 

F1:: ListenForMultiplePresses(func("F1Handler"))
F2:: ListenForMultiplePresses(func("F2Handler"))

ListenForMultiplePresses(pressHandler, listenLength := 400) {
	Global keyPresses
	If ((A_PriorHotkey = A_ThisHotkey) && (keyPresses > 0)) {
		keyPresses += 1
		Return
	}
	keyPresses := 1
	SetTimer, %pressHandler%, %listenLength%
}

F1Handler() {
	Global keyPresses
	Static Items := ["once", "twice", "twice+"]
	MsgBox, % "F1 pressed " Items[keyPresses]
	SetTimer, F1Handler, Off
	keyPresses := 0
}

F2Handler() {
	Global keyPresses
	Static Items := ["once", "twice", "twice+"]
	MsgBox, % "F2 pressed " Items[keyPresses]
	SetTimer, F2Handler, Off
	keyPresses := 0
}

[GollyJer]

Hi Delta. Thanks for the response.
Ultimately I will be doing different things with each keyPress so shortening the code isn't the primary issue.

What I really need help with is tracking keyPress count independently for each handler.

[Barney]

Then use separate variables for each key.

[GollyJer]

Then use separate variables for each key.

That would entail creating a separate ListenForMultiplePresses for each hotkey wouldn't it? I'm hoping for a more OOP way of figuring this out.