Functions within function error code? Topic is solved

[hulk_smash]

Hello friends,

I have some code that worked before attempting to add some validations with pixel searches...

Getting error at line 390
line text: findfish()
Error: functions cannot contain functions.

Below is the code:

Code: Select all

;************************************************************************
;	barbarian fishing with mechanism to only drop fish in inventory
;************************************************************************

;************************************************************************
;	color search function for purpleish box to resume fish after dropping
;	PixelSearch A000A0
;************************************************************************

;************************************************************************
;	color search small red box to see if fishing or not 29, 47, 109, 61 
;	PixelSearch FF0000
;************************************************************************


PgUp::main()

main(){

loop {

	Random, SleepX, 2500, 3500
	sleep, SleepX

	PixelSearch, XXX, YYY, 29, 47, 109, 61, 0xFF0000, 1, FastRGB
	if (ErrorLevel = 0){

;dropping it

	Send {shift down}
	
;dropping row 1, but not the rod and bait/feathers

	PixelSearch, PX, PY, 1791, 788, 1814, 809 0xFFFF00, 1, FastRGB
	if (ErrorLevel = 0){
	Random, R1, 787, 810
	Random, C3, 1790, 1816
	Mousemove, C3, R1, 3
	click
	Random, Sleeper, 90, 105
	sleep, Sleeper }
	else{
	Send {shift up}
	findfish() }

	PixelSearch, PX, PY, 1832, 788, 1857, 809 0xFFFF00, 1, FastRGB
	if (ErrorLevel = 0){	
	Random, R1, 787, 810
	Random, C4, 1832, 1857
	Mousemove, C4, R1, 3
	click
	Random, Sleeper, 90, 105
	sleep, Sleeper }
	else{
	Send {shift up}
	findfish() }	
	
;dropping row 2	

	PixelSearch, PX, PY, 1706, 825, 1732, 847 0xFFFF00, 1, FastRGB
	if (ErrorLevel = 0){
	Random, C1, 1706, 1732
	Random, R2, 825, 847
	Mousemove, C1, R2, 3
	click
	Random, Sleeper, 90, 105
	sleep, Sleeper }
	else{
	Send {shift up}
	findfish() }

	PixelSearch, PX, PY, 1748, 825, 1774, 847 0xFFFF00, 1, FastRGB
	if (ErrorLevel = 0){	
	Random, C2, 1748, 1774
	Random, R2, 825, 847
	Mousemove, C2, R2, 3
	click
	Random, Sleeper, 90, 105
	sleep, Sleeper }
	else{
	Send {shift up}	
	findfish() }	

	PixelSearch, PX, PY, 1790, 825, 1816, 847 0xFFFF00, 1, FastRGB
	if (ErrorLevel = 0){		
	Random, C3, 1790, 1816
	Random, R2, 825, 847
	Mousemove, C3, R2, 3
	click
	Random, Sleeper, 90, 105
	sleep, Sleeper }
	else{
	Send {shift up}	
	findfish() }	

	PixelSearch, PX, PY, 1832, 825, 1857, 847 0xFFFF00, 1, FastRGB
	if (ErrorLevel = 0){	
	Random, C4, 1832, 1857
	Random, R2, 825, 847
	Mousemove, C4, R2, 3
	click
	Random, Sleeper, 90, 105
	sleep, Sleeper }
	else{
	Send {shift up}	
	findfish() }		

;dropping row 3	

	PixelSearch, PX, PY, 1706, 858, 1732, 884 0xFFFF00, 1, FastRGB
	if (ErrorLevel = 0){
	Random, C1, 1706, 1732
	Random, R3, 858, 884
	Mousemove, C1, R3, 3
	click
	Random, Sleeper, 90, 105
	sleep, Sleeper }
	else{
	Send {shift up}	
	findfish() }

	PixelSearch, PX, PY, 1748, 858, 1774, 884 0xFFFF00, 1, FastRGB
	if (ErrorLevel = 0){	
	Random, C2, 1748, 1774
	Random, R3, 858, 884
	Mousemove, C2, R3, 3
	click
	Random, Sleeper, 90, 105
	sleep, Sleeper }
	else{
	Send {shift up}	
	findfish() }	

	PixelSearch, PX, PY, 1790, 858, 1816, 884 0xFFFF00, 1, FastRGB
	if (ErrorLevel = 0){		
	Random, C3, 1790, 1816
	Random, R3, 858, 884
	Mousemove, C3, R3, 3
	click
	Random, Sleeper, 90, 105
	sleep, Sleeper }
	else{
	Send {shift up}	
	findfish() }

	PixelSearch, PX, PY, 1832, 858, 1857, 884 0xFFFF00, 1, FastRGB
	if (ErrorLevel = 0){		
	Random, C4, 1832, 1857
	Random, R3, 858, 884
	Mousemove, C4, R3, 3
	click
	Random, Sleeper, 90, 105
	sleep, Sleeper }
	else{
	Send {shift up}	
	findfish() }
	
;dropping row 4	

	PixelSearch, PX, PY, 1706, 896, 1732, 921 0xFFFF00, 1, FastRGB
	if (ErrorLevel = 0){	
	Random, C1, 1706, 1732
	Random, R4, 896, 921
	Mousemove, C1, R4, 3
	click
	Random, Sleeper, 90, 105
	sleep, Sleeper }
	else{
	Send {shift up}	
	findfish() }

	PixelSearch, PX, PY, 1748, 896, 1774, 921 0xFFFF00, 1, FastRGB
	if (ErrorLevel = 0){	
	Random, C2, 1748, 1774
	Random, R4, 896, 921
	Mousemove, C2, R4, 3
	click
	Random, Sleeper, 90, 105
	sleep, Sleeper }
	else{
	Send {shift up}	
	findfish() }

	PixelSearch, PX, PY, 1790, 896, 1816, 921 0xFFFF00, 1, FastRGB
	if (ErrorLevel = 0){	
	Random, C3, 1790, 1816
	Random, R4, 896, 921
	Mousemove, C3, R4, 3
	click
	Random, Sleeper, 90, 105
	sleep, Sleeper }
	else{
	Send {shift up}	
	findfish() }

	PixelSearch, PX, PY, 1832, 896, 1857, 921 0xFFFF00, 1, FastRGB
	if (ErrorLevel = 0){
	Random, C4, 1832, 1857
	Random, R4, 896, 921
	Mousemove, C4, R4, 3
	click
	Random, Sleeper, 90, 105
	sleep, Sleeper }
	else{
	Send {shift up}	
	findfish() }
	
;dropping row 5	

	PixelSearch, PX, PY, 1706, 931, 1732, 957 0xFFFF00, 1, FastRGB
	if (ErrorLevel = 0){		
	Random, C1, 1706, 1732
	Random, R5, 931, 957
	Mousemove, C1, R5, 3
	click
	Random, Sleeper, 90, 105
	sleep, Sleeper }
	else{
	Send {shift up}	
	findfish() }

	PixelSearch, PX, PY, 1748, 931, 1774, 957 0xFFFF00, 1, FastRGB
	if (ErrorLevel = 0){		
	Random, C2, 1748, 1774
	Random, R5, 931, 957
	Mousemove, C2, R5, 3
	click
	Random, Sleeper, 90, 105
	sleep, Sleeper }
	else{
	Send {shift up}	
	findfish() }

	PixelSearch, PX, PY, 1790, 931, 1816, 957 0xFFFF00, 1, FastRGB
	if (ErrorLevel = 0){		
	Random, C3, 1790, 1816
	Random, R5, 931, 957
	Mousemove, C3, R5, 3
	click
	Random, Sleeper, 90, 105
	sleep, Sleeper }
	else{
	Send {shift up}	
	findfish() }

	PixelSearch, PX, PY, 1832, 931, 1857, 957 0xFFFF00, 1, FastRGB
	if (ErrorLevel = 0){	
	Random, C4, 1832, 1857
	Random, R5, 931, 957
	Mousemove, C4, R5, 3
	click
	Random, Sleeper, 90, 105
	sleep, Sleeper }
	else{
	Send {shift up}	
	findfish() }
	
;dropping row 6	

	PixelSearch, PX, PY, 1706, 977, 1732, 991 0xFFFF00, 1, FastRGB
	if (ErrorLevel = 0){	
	Random, C1, 1706, 1732
	Random, R6, 977, 991
	Mousemove, C1, R6, 3
	click
	Random, Sleeper, 90, 105
	sleep, Sleeper }
	else{
	Send {shift up}	
	findfish() }

	PixelSearch, PX, PY, 1748, 977, 1774, 991 0xFFFF00, 1, FastRGB
	if (ErrorLevel = 0){	
	Random, C2, 1748, 1774
	Random, R6, 977, 991
	Mousemove, C2, R6, 3
	click
	Random, Sleeper, 90, 105
	sleep, Sleeper }
	else{
	Send {shift up}	
	findfish() }

	PixelSearch, PX, PY, 1790, 977, 1816, 991 0xFFFF00, 1, FastRGB
	if (ErrorLevel = 0){	
	Random, C3, 1790, 1816
	Random, R6, 977, 991
	Mousemove, C3, R6, 3
	click
	Random, Sleeper, 90, 105
	sleep, Sleeper }
	else{
	Send {shift up}	
	findfish() }

	PixelSearch, PX, PY, 1832, 977, 1857, 991 0xFFFF00, 1, FastRGB
	if (ErrorLevel = 0){
	Random, C4, 1832, 1857
	Random, R6, 977, 991
	Mousemove, C4, R6, 3
	click
	Random, Sleeper, 90, 105
	sleep, Sleeper }
	else{
	Send {shift up}	
	findfish() }
	
;dropping row 7	

	PixelSearch, PX, PY, 1706, 1004, 1732, 1025 0xFFFF00, 1, FastRGB
	if (ErrorLevel = 0){	
	Random, C1, 1706, 1732
	Random, R7, 1004, 1025
	Mousemove, C1, R7, 3
	click
	Random, Sleeper, 90, 105
	sleep, Sleeper }
	else{
	Send {shift up}	
	findfish() }

	PixelSearch, PX, PY, 1748, 1004, 1774, 1025 0xFFFF00, 1, FastRGB
	if (ErrorLevel = 0){	
	Random, C2, 1748, 1774
	Random, R7, 1004, 1025
	Mousemove, C2, R7, 3
	click
	Random, Sleeper, 90, 105
	sleep, Sleeper }
	else{
	Send {shift up}	
	findfish() }

	PixelSearch, PX, PY, 1790, 1004, 1816, 1025 0xFFFF00, 1, FastRGB
	if (ErrorLevel = 0){	
	Random, C3, 1790, 1816
	Random, R7, 1004, 1025
	Mousemove, C3, R7, 3
	click
	Random, Sleeper, 90, 105
	sleep, Sleeper }
	else{
	Send {shift up}	
	findfish() }

	PixelSearch, PX, PY, 1832, 1004, 1857, 1025 0xFFFF00, 1, FastRGB
	if (ErrorLevel = 0){	
	Random, C4, 1832, 1857
	Random, R7, 1004, 1025
	Mousemove, C4, R7, 3
	click
	Random, Sleeper, 90, 105
	sleep, Sleeper }
	else {
	Send {shift up}	
	findfish()
	}
	
	Random, VariableY ,500, 750
	sleep, VariableY

	}

	}

}

findfish(){

	PixelSearch, fishX, fishY, 1050, 977, 955, 220, 0xA000A0, 1, Fast
	if (ErrorLevel = 0) {
		fishX -= 20
		fishY -= 10
		Mousemove, fishX, fishY, 2
		click
		sleep 3000
		
		main()
		
		}
	}

2::reload
3::exitapp

[Mod edit: [code][/code] tags added.]

[Rohwedder]

Hallo,
try (untested):

Code: Select all

;************************************************************************
;	barbarian fishing with mechanism to only drop fish in inventory
;************************************************************************
;************************************************************************
;	color search function for purpleish box to resume fish after dropping
;	PixelSearch A000A0
;************************************************************************
;************************************************************************
;	color search small red box to see if fishing or not 29, 47, 109, 61
;	PixelSearch FF0000
;************************************************************************
PgUp::main()
main()
{
	loop
	{
		Random, SleepX, 2500, 3500
		sleep, SleepX
		PixelSearch, XXX, YYY, 29, 47, 109, 61, 0xFF0000, 1, FastRGB
		if (ErrorLevel = 0)
		{
			;dropping it
			Send {shift down}
			;dropping row 1, but not the rod and bait/feathers
			PixelSearch, PX, PY, 1791, 788, 1814, 809 0xFFFF00, 1, FastRGB
			if (ErrorLevel = 0)
			{
				Random, R1, 787, 810
				Random, C3, 1790, 1816
				Mousemove, C3, R1, 3
				click
				Random, Sleeper, 90, 105
				sleep, Sleeper
			}
			else
			{
				Send {shift up}
				Findfish()
			}
			PixelSearch, PX, PY, 1832, 788, 1857, 809 0xFFFF00, 1, FastRGB
			if (ErrorLevel = 0)
			{
				Random, R1, 787, 810
				Random, C4, 1832, 1857
				Mousemove, C4, R1, 3
				click
				Random, Sleeper, 90, 105
				sleep, Sleeper
			}
			else
			{
				Send {shift up}
				Findfish()
			}
			;dropping row 2
			PixelSearch, PX, PY, 1706, 825, 1732, 847 0xFFFF00, 1, FastRGB
			if (ErrorLevel = 0)
			{
				Random, C1, 1706, 1732
				Random, R2, 825, 847
				Mousemove, C1, R2, 3
				click
				Random, Sleeper, 90, 105
				sleep, Sleeper
			}
			else
			{
				Send {shift up}
				Findfish()
			}
			PixelSearch, PX, PY, 1748, 825, 1774, 847 0xFFFF00, 1, FastRGB
			if (ErrorLevel = 0)
			{
				Random, C2, 1748, 1774
				Random, R2, 825, 847
				Mousemove, C2, R2, 3
				click
				Random, Sleeper, 90, 105
				sleep, Sleeper
			}
			else
			{
				Send {shift up}
				Findfish()
			}
			PixelSearch, PX, PY, 1790, 825, 1816, 847 0xFFFF00, 1, FastRGB
			if (ErrorLevel = 0)
			{
				Random, C3, 1790, 1816
				Random, R2, 825, 847
				Mousemove, C3, R2, 3
				click
				Random, Sleeper, 90, 105
				sleep, Sleeper
			}
			else
			{
				Send {shift up}
				Findfish()
			}
			PixelSearch, PX, PY, 1832, 825, 1857, 847 0xFFFF00, 1, FastRGB
			if (ErrorLevel = 0)
			{
				Random, C4, 1832, 1857
				Random, R2, 825, 847
				Mousemove, C4, R2, 3
				click
				Random, Sleeper, 90, 105
				sleep, Sleeper
			}
			else
			{
				Send {shift up}
				Findfish()
			}
			;dropping row 3
			PixelSearch, PX, PY, 1706, 858, 1732, 884 0xFFFF00, 1, FastRGB
			if (ErrorLevel = 0)
			{
				Random, C1, 1706, 1732
				Random, R3, 858, 884
				Mousemove, C1, R3, 3
				click
				Random, Sleeper, 90, 105
				sleep, Sleeper
			}
			else
			{
				Send {shift up}
				Findfish()
			}
			PixelSearch, PX, PY, 1748, 858, 1774, 884 0xFFFF00, 1, FastRGB
			if (ErrorLevel = 0)
			{
				Random, C2, 1748, 1774
				Random, R3, 858, 884
				Mousemove, C2, R3, 3
				click
				Random, Sleeper, 90, 105
				sleep, Sleeper
			}
			else
			{
				Send {shift up}
				Findfish()
			}
			PixelSearch, PX, PY, 1790, 858, 1816, 884 0xFFFF00, 1, FastRGB
			if (ErrorLevel = 0)
			{
				Random, C3, 1790, 1816
				Random, R3, 858, 884
				Mousemove, C3, R3, 3
				click
				Random, Sleeper, 90, 105
				sleep, Sleeper
			}
			else
			{
				Send {shift up}
				Findfish()
			}
			PixelSearch, PX, PY, 1832, 858, 1857, 884 0xFFFF00, 1, FastRGB
			if (ErrorLevel = 0)
			{
				Random, C4, 1832, 1857
				Random, R3, 858, 884
				Mousemove, C4, R3, 3
				click
				Random, Sleeper, 90, 105
				sleep, Sleeper
			}
			else
			{
				Send {shift up}
				Findfish()
			}
			;dropping row 4
			PixelSearch, PX, PY, 1706, 896, 1732, 921 0xFFFF00, 1, FastRGB
			if (ErrorLevel = 0)
			{
				Random, C1, 1706, 1732
				Random, R4, 896, 921
				Mousemove, C1, R4, 3
				click
				Random, Sleeper, 90, 105
				sleep, Sleeper
			}
			else
			{
				Send {shift up}
				Findfish()
			}
			PixelSearch, PX, PY, 1748, 896, 1774, 921 0xFFFF00, 1, FastRGB
			if (ErrorLevel = 0)
			{
				Random, C2, 1748, 1774
				Random, R4, 896, 921
				Mousemove, C2, R4, 3
				click
				Random, Sleeper, 90, 105
				sleep, Sleeper
			}
			else
			{
				Send {shift up}
				Findfish()
			}
			PixelSearch, PX, PY, 1790, 896, 1816, 921 0xFFFF00, 1, FastRGB
			if (ErrorLevel = 0)
			{
				Random, C3, 1790, 1816
				Random, R4, 896, 921
				Mousemove, C3, R4, 3
				click
				Random, Sleeper, 90, 105
				sleep, Sleeper
			}
			else
			{
				Send {shift up}
				Findfish()
			}
			PixelSearch, PX, PY, 1832, 896, 1857, 921 0xFFFF00, 1, FastRGB
			if (ErrorLevel = 0)
			{
				Random, C4, 1832, 1857
				Random, R4, 896, 921
				Mousemove, C4, R4, 3
				click
				Random, Sleeper, 90, 105
				sleep, Sleeper
			}
			else
			{
				Send {shift up}
				Findfish()
			}
			;dropping row 5
			PixelSearch, PX, PY, 1706, 931, 1732, 957 0xFFFF00, 1, FastRGB
			if (ErrorLevel = 0)
			{
				Random, C1, 1706, 1732
				Random, R5, 931, 957
				Mousemove, C1, R5, 3
				click
				Random, Sleeper, 90, 105
				sleep, Sleeper
			}
			else
			{
				Send {shift up}
				Findfish()
			}
			PixelSearch, PX, PY, 1748, 931, 1774, 957 0xFFFF00, 1, FastRGB
			if (ErrorLevel = 0)
			{
				Random, C2, 1748, 1774
				Random, R5, 931, 957
				Mousemove, C2, R5, 3
				click
				Random, Sleeper, 90, 105
				sleep, Sleeper
			}
			else
			{
				Send {shift up}
				Findfish()
			}
			PixelSearch, PX, PY, 1790, 931, 1816, 957 0xFFFF00, 1, FastRGB
			if (ErrorLevel = 0)
			{
				Random, C3, 1790, 1816
				Random, R5, 931, 957
				Mousemove, C3, R5, 3
				click
				Random, Sleeper, 90, 105
				sleep, Sleeper
			}
			else
			{
				Send {shift up}
				Findfish()
			}
			PixelSearch, PX, PY, 1832, 931, 1857, 957 0xFFFF00, 1, FastRGB
			if (ErrorLevel = 0)
			{
				Random, C4, 1832, 1857
				Random, R5, 931, 957
				Mousemove, C4, R5, 3
				click
				Random, Sleeper, 90, 105
				sleep, Sleeper
			}
			else
			{
				Send {shift up}
				Findfish()
			}
			;dropping row 6
			PixelSearch, PX, PY, 1706, 977, 1732, 991 0xFFFF00, 1, FastRGB
			if (ErrorLevel = 0)
			{
				Random, C1, 1706, 1732
				Random, R6, 977, 991
				Mousemove, C1, R6, 3
				click
				Random, Sleeper, 90, 105
				sleep, Sleeper
			}
			else
			{
				Send {shift up}
				Findfish()
			}
			PixelSearch, PX, PY, 1748, 977, 1774, 991 0xFFFF00, 1, FastRGB
			if (ErrorLevel = 0)
			{
				Random, C2, 1748, 1774
				Random, R6, 977, 991
				Mousemove, C2, R6, 3
				click
				Random, Sleeper, 90, 105
				sleep, Sleeper
			}
			else
			{
				Send {shift up}
				Findfish()
			}
			PixelSearch, PX, PY, 1790, 977, 1816, 991 0xFFFF00, 1, FastRGB
			if (ErrorLevel = 0)
			{
				Random, C3, 1790, 1816
				Random, R6, 977, 991
				Mousemove, C3, R6, 3
				click
				Random, Sleeper, 90, 105
				sleep, Sleeper
			}
			else
			{
				Send {shift up}
				Findfish()
			}
			PixelSearch, PX, PY, 1832, 977, 1857, 991 0xFFFF00, 1, FastRGB
			if (ErrorLevel = 0)
			{
				Random, C4, 1832, 1857
				Random, R6, 977, 991
				Mousemove, C4, R6, 3
				click
				Random, Sleeper, 90, 105
				sleep, Sleeper
			}
			else
			{
				Send {shift up}
				Findfish()
			}
			;dropping row 7
			PixelSearch, PX, PY, 1706, 1004, 1732, 1025 0xFFFF00, 1, FastRGB
			if (ErrorLevel = 0)
			{
				Random, C1, 1706, 1732
				Random, R7, 1004, 1025
				Mousemove, C1, R7, 3
				click
				Random, Sleeper, 90, 105
				sleep, Sleeper
			}
			else
			{
				Send {shift up}
				Findfish()
			}
			PixelSearch, PX, PY, 1748, 1004, 1774, 1025 0xFFFF00, 1, FastRGB
			if (ErrorLevel = 0)
			{
				Random, C2, 1748, 1774
				Random, R7, 1004, 1025
				Mousemove, C2, R7, 3
				click
				Random, Sleeper, 90, 105
				sleep, Sleeper
			}
			else
			{
				Send {shift up}
				Findfish()
			}
			PixelSearch, PX, PY, 1790, 1004, 1816, 1025 0xFFFF00, 1, FastRGB
			if (ErrorLevel = 0)
			{
				Random, C3, 1790, 1816
				Random, R7, 1004, 1025
				Mousemove, C3, R7, 3
				click
				Random, Sleeper, 90, 105
				sleep, Sleeper
			}
			else
			{
				Send {shift up}
				Findfish()
			}
			PixelSearch, PX, PY, 1832, 1004, 1857, 1025 0xFFFF00, 1, FastRGB
			if (ErrorLevel = 0)
			{
				Random, C4, 1832, 1857
				Random, R7, 1004, 1025
				Mousemove, C4, R7, 3
				click
				Random, Sleeper, 90, 105
				sleep, Sleeper
			}
			else
			{
				Send {shift up}
				findfish()
			}
			Random, VariableY ,500, 750
			sleep, VariableY
		}
	}
}
findfish()
{
	PixelSearch, fishX, fishY, 1050, 977, 955, 220, 0xA000A0, 1, Fast
	if (ErrorLevel = 0)
	{
		fishX -= 20
		fishY -= 10
		Mousemove, fishX, fishY, 2
		click
		sleep 3000
		main()
	}
}
2::reload
3::exitapp

The block's ending brace must not be placed on the same line as the block's controlling statement, but below it on a separate line.

Code: Select all

sleep, Sleeper } ;wrong!
findfish() } ;wrong!

My personal opinion: One True Brace (OTB, K&R style) is more shit than chic!

[hulk_smash]

Thank you for the formatting, this resolved the error I was having before.

There is something else strange going on with the code. It is finding the first box that let's the user know to start checking the inventory and dropping the bounty. Right now the code just sends shift down and gets stuck. Any ideas?

[Rohwedder]

Check your PixelSearch lines. some are missing the comma before the color:
e.g. PixelSearch, PX, PY, 1791, 788, 1814, 809 0xFFFF00, 1, FastRGB
should probably look like this:
PixelSearch, PX, PY, 1791, 788, 1814, 809, 0xFFFF00, 1, FastRGB

[hulk_smash]

Oh dear, haha. It would appear that all of them except the first were messed up.