If, and statement

[TrebleTA]

Why is it that if i have say..

Code: Select all

aaa=1
bbb=2
If aaa=1 and bbb=2

I do the above yet even tho bbb=2 its not registering, so i am having to do it like this,

Code: Select all

if aaa=1
{
         if bbb=2
        {
         }
}

was wondering why?

[boiler]

Code: Select all

If (aaa=1) and (bbb=2)

It's because you are using the legacy If statement rather than the If (expression) statement.

[mikeyww]

I was writing as boiler was.

Code: Select all

aaa=1
bbb=2
c=1 and bbb=2
d := "1 and bbb=2"
If (aaa=1 and bbb=2)
 Send x
If d=1 and bbb=2
 Send y

Explained: If • Legacy If patterns

[just me]

Code: Select all

If (aaa=1) and (bbb=2)

If (Expression)

[TrebleTA]

Thanks so i was missing the () in the if statement.

also this next statement

Code: Select all

Process, Exist, this process has spaces.exe

Should it be as there is spaces

Code: Select all

Process, Exist, "this process has spaces.exe"

[TrebleTA]

also say the if statement if its just say if aaa=1 is that ok or should that is also

Code: Select all

if (aaa=1)

[mikeyww]

Try it. See if it works. That is the beauty. You can test it without anyone's permission!

[TrebleTA]

the if statement well i was doing like

Code: Select all

if  !errorlevel & winexist(ahk_exe this) & winexist(ahk_exe thisb) & aaa =1 or !errorlevel & winexist(ahk_exe check2) & winexist(ahk_exe check2) & aaa=1

But the aaa was not getting noticed.
I now have its like

Code: Select all

if  !errorlevel
{
	if  winexist(ahk_exe this) & winexist(ahk_exe thisb) or !errorlevel & winexist(ahk_exe check2) & winexist(ahk_exe check2)
	{
		if aaa=1
		{
		run, my task or process's
		}
	}
}

but as someone has said, its the () I was missing, Thank you. T
The other. I just wanting to know if its the correct way to have " " if its linked to like program files x86
or as i linked above?

[boiler]

& is not the shorthand version of logical and. It is the bit-wise "and" that you use for choosing 0s and 1s (will be 1 only if both are 1) at a byte/bit level. The shorthand for logical and is &&.

Where did you see that you are supposed to put quotes around a process name if it has spaces in the Process, Exist command? I haven't seen that and it doesn't make sense that it would be needed.

[TrebleTA]

or even should it be ("this process has spaces.exe")

[TrebleTA]

thanks for the reply well i have this.

Code: Select all

	Process, Exist, Intelligent standby list cleaner ISLC.exe
	If !ErrorLevel																	; If the task is NOT running

But its not detecting it is running
p.s thanks for the update with the & in my script i do use and, but its good to know the correct way. and & alone being wrong

[boiler]

Regarding ("..."), I think you are confusing where you see this in the documentation:

Code: Select all

DllCall("GetCurrentProcessId")

And that doesn't have to do with whether there are spaces or not. When parentheses are used in situations like that, it's because it's a function call, and the parameter is an expression. And with expressions, literal strings are quoted. The process name parameter in the Process command is not an expression.

[TrebleTA]

so why is it not always detecting the process is running?
sorry for the edit, i have others that detect fine its just this one process that seems to get missed somehow why i was thinking were am i going wrong

[boiler]

Just confirmed that quotation marks are not only not needed when there are spaces in the process name, but it will not work if they are included.

Are you sure you have the name of the process correct? Can you show it in Task Manager?

[boiler]

You have a problem with your statements like this:

Code: Select all

if  !errorlevel & winexist(ahk_exe this) & winexist(ahk_exe thisb) & aaa =1 or !errorlevel & winexist(ahk_exe check2) & winexist(ahk_exe check2) & aaa=1

You need quotation marks inside the parameters to function calls because they are expressions and you are passing literal strings. So winexist(ahk_exe this) must be winexist("ahk_exe this"). Unless this is a variable containing the process name, then it would be winexist("ahk_exe " this).

Also, you should check the logic of your compound statements with multiple ands (remember to change them to &&) and an or. You may need to be grouping various parts using parentheses.

[RussF]

Code: Select all

if  !errorlevel & winexist(ahk_exe this) & winexist(ahk_exe thisb) & aaa =1 or !errorlevel & winexist(ahk_exe check2) & winexist(ahk_exe check2) & aaa=1

could be:

Code: Select all

if (!errorlevel && aaa=1) && ((winexist(ahk_exe this) && winexist(ahk_exe thisb)) || winexist(ahk_exe check2))

You have winexist(ahk_exe check2) checked twice.

Russ

Edit: Oops, forgot an "&" - thanks @mikeyww!

[mikeyww]

Using bitwise instead of logical AND for WinExist can lead to an unexpected result, because WinExist returns a HWND.

[boiler]

I believe some things are in there twice because it's two groupings of a series of "and"s that are separated by an "or". And it is desired that that part be true in either of the "or" segments. So I think it's actually meant to be in there twice for good reason. The things you took out of one side probably need to be true in that other side as well. To show the grouping with parentheses:

Code: Select all

if  (!errorlevel && winexist("ahk_exe this") && winexist("ahk_exe thisb") && aaa =1) or (!errorlevel && winexist("ahk_exe check2") && winexist("ahk_exe check2") && aaa=1)

(well, actually, the extra check2 part could come out, but I can see why !errorlevel and aaa=1 is in there twice)

[RussF]

My post has been edited. Thanks @mikeyww!

Russ

[boiler]

And if the intended grouping is as I indicated with parentheses, then the parentheses are not needed because of order of precedence of the operators, as this demonstrates (result is 1):

Code: Select all

MsgBox, % 1 && 1 || 0 && 1

(actually, I don't think that's a definitive demonstration, but I think the point is still true)