unneeded DynaCall code? Topic is solved

Get help with using AutoHotkey (v1.1 and older) and its commands and hotkeys
swagfag
Posts: 6222
Joined: 11 Jan 2017, 17:59

unneeded DynaCall code?

Post by swagfag » 24 Sep 2021, 13:53

@lexikos whats this code for? https://github.com/Lexikos/AutoHotkey_L/blame/093b8084da1f5772e310ca78a6463be1d3c57460/source/script2.cpp#L12717-L12724
it looks like it can never run. on 32bit, for aRet a hardcoded NULL is passed and this function is being called only from this exact one place

lexikos
Posts: 9583
Joined: 30 Sep 2013, 04:07
Contact:

Re: unneeded DynaCall code?  Topic is solved

Post by lexikos » 25 Sep 2021, 00:10

I assume it is part of the original DynaCall or whatever code DynaCall was based on, by the author indicated in the comments (Ton Plooy). It would probably be used for struct return values.

According to my brief check, the compiler already omits that code. Function inlining would allow the optimizer to see that one (or all) of the conditions are always false.

Post Reply

Return to “Ask for Help (v1)”