v2 Buffer static constructor call() should be on top

Share your ideas as to how the documentation can be improved.
iseahound
Posts: 1434
Joined: 13 Aug 2016, 21:04
Contact:

v2 Buffer static constructor call() should be on top

Post by iseahound » 17 May 2021, 20:09

https://lexikos.github.io/v2/docs/objects/Buffer.htm

Input parameters are found on the bottom.

Pull request sent.

User avatar
Ragnar
Posts: 611
Joined: 30 Sep 2013, 15:25

Re: v2 Buffer static constructor call() should be on top

Post by Ragnar » 18 May 2021, 02:37

Pull request sent.
No, it wasn't. There is no new PR in https://github.com/Lexikos/AutoHotkey_L-Docs/pulls. This is just a friendly hint - not that you wonder why there is never any response :)

iseahound
Posts: 1434
Joined: 13 Aug 2016, 21:04
Contact:

Re: v2 Buffer static constructor call() should be on top

Post by iseahound » 18 May 2021, 09:39

I'm new to editing the github. Which branch do I edit? v2 or patch v1?

Nevermind, I figured it out. Do you normally batch the changes? Is there anything else I need to know or do?

User avatar
Ragnar
Posts: 611
Joined: 30 Sep 2013, 15:25

Re: v2 Buffer static constructor call() should be on top

Post by Ragnar » 19 May 2021, 03:30

Do you normally batch the changes?
Yes, but is not mandatory in this way. Anyone can create PRs themselves.
Is there anything else I need to know or do?
Regarding your PR, no. You just have to wait and hope that Lexikos accepts your PR.

lexikos
Posts: 9559
Joined: 30 Sep 2013, 04:07
Contact:

Re: v2 Buffer static constructor call() should be on top

Post by lexikos » 19 May 2021, 06:08

If you compare to Array and Map, you may note that Call is the first section, but not listed first in the index. The reason for this is:
In addition to the methods and property inherited from Object, Buffer objects have the following predefined properties:
Static Methods:
• Call

Properties:
...
Buffer objects do not have a Call property.

iseahound
Posts: 1434
Joined: 13 Aug 2016, 21:04
Contact:

Re: v2 Buffer static constructor call() should be on top

Post by iseahound » 19 May 2021, 13:00

Ah. Okay it's fixed.

Post Reply

Return to “Suggestions on Documentation Improvements”