What's wrong with Else If

[Muhammadi]

Hi,

The problem is with my incorrect usage of Else If.
Please let me know where I made the mistake.

Thanks,
Muhammadi

Code: Select all

CoordMode, Pixel, Window
ImageSearch, FoundX, FoundY, 334, 456, 416, 491, C:\Users\KILLERWHALE\AppData\Roaming\MacroCreator\Screenshots\Screen_20210531073118.png
Sleep, 1111
If (ErrorLevel)
{
    CoordMode, Pixel, Window
    ImageSearch, FoundX, FoundY, 330, 459, 419, 510, C:\Users\KILLERWHALE\AppData\Roaming\MacroCreator\Screenshots\Screen_20210531165725.png
    CenterImgSrchCoords("C:\Users\KILLERWHALE\AppData\Roaming\MacroCreator\Screenshots\Screen_20210531165725.png", FoundX, FoundY)
    Sleep, 1111
}
Else If (ErrorLevel)
{
    MsgBox, 0, , A
}
Else
{
    MsgBox, 0, , B
}

[Mod edit: [code][/code] tags added.]

[Muhammadi]

When I remove Else If and one of the Image Searches, everything works fine.
But with Else If it doesn't give any result, it doesn't give any message.

I incorrectly used Else If.
Please let me know where I made the mistake.

Can someone write a similar simple macro with a couple of Image Searches that works and send me the script?

[gregster]

So what is the goal, which branch should be triggered if the first image is found (If !errorlevel) ?

what are the three cases you are trying to distinguish? Errorlevel 0, 1 and 2 ?
or just 'Image found' vs 'Image not found' (two cases) ? But for both imagesearches?

please describe exactly what should happen!
It's not clear from the code or the request.

[Muhammadi]

The goal:
Look for the first image;
If you didn't find the first image, look for the second image;
If you didn't find the second image, then give the message A;
otherwise give the message B.

In other words:
If you didn't find neither image 1 nor 2, give message A.
If you found either image 1 or 2, give message B.

I've attached a screenshot of the macro.

[gregster]

In other words:
If you didn't find neither image 1 nor 2, give message A.
If you found either image 1 or 2, give message B.

Try

Code: Select all

CoordMode, Pixel, Window
ImageSearch, FoundX, FoundY, 334, 456, 416, 491, C:\Users\KILLERWHALE\AppData\Roaming\MacroCreator\Screenshots\Screen_20210531073118.png
Sleep, 1111
If (ErrorLevel)		; if Image 1 not found 
{
  	CoordMode, Pixel, Window
  	ImageSearch, FoundX, FoundY, 330, 459, 419, 510, C:\Users\KILLERWHALE\AppData\Roaming\MacroCreator\Screenshots\Screen_20210531165725.png
  	CenterImgSrchCoords("C:\Users\KILLERWHALE\AppData\Roaming\MacroCreator\Screenshots\Screen_20210531165725.png", FoundX, FoundY)
  	Sleep, 1111
	If (ErrorLevel)		; if image 2 wasn't found either
	{
    	MsgBox, 0, , A
	}
}

If !(ErrorLevel)		; if Errorlevel is 0  =  either image 1 or 2 was found
	MsgBox, 0, , B

[Muhammadi]

Code: Select all

If !(ErrorLevel)		; if Errorlevel is 0  =  either image 1 or 2 was found

Can you tell me how to write this one in PMC?

[gregster]

Not really, sorry, never used it.

But ! means (logical) not. You could also check If (Errorlevel = 0) for this, if that's easier to find - meaning 'Image found'.

Looking at the screenshot, it could be something like If Image/Pixel Found or something equivalent - but that's just a guess.

[Muhammadi]

@gregster
I wrote your script, it didn't work.
Thanks anyway.