225 replies to this topic

[Lexikos]

Regarding your post, I don't understand the bug you mention?

I already said, it prevents hotstrings(k) from removing k from the list of expressions. For example,

hotstrings("\bann(a|e)" , "Ann%$1%")
; This is supposed to "remove hotstring definition from triggering an action":
hotstrings("\bann(a|e)")

Your second change breaks entries like ...

I forgot to replace "$" with "$$" in k and a. For example,

t := RegExReplace(t, "\n\Q" . k . "\E\r.*?\n|$", "`n" RegExReplace(k,"\$","$$$$") "`r" RegExReplace(a,"\$","$$$$") "`n", _, 1)

Notice that the replacement string is actually "$$", with each doubled up to specify a single literal character.

If possible please post back on the problem there and what difference changing that line should make.

Again, I already said what it does: replaces any identical expressions already existing in the list. For instance, without the change, code like the following

hotstrings("omg" , "oh my god")
Sleep, 5000
hotstrings("omg" , "oh my god{!}")

will result in "omg" being expanded to "oh my god oh my god!" if the script has been running for at least 5 seconds. This is because there are two "omg" entries in the list (but also because of the first issue in the list below.)

Both of these changes are specifically useful for loading hotstring definitions from an external file, and later reloading them or modifying them via a GUI. (Someone Asked for Help with such a script recently.)

While debugging this, I've noticed some other issues:
[*:145j8knn]Sometimes the "recognizer" seems to act on what was there, not what it was replaced with. (One could argue that neither should be recognized, but that's not the point.) For instance, if I use hotstrings("\bann(a|e)", "Ann%$1%") and type "anna", it replaces it with "Anna". If I then backspace the "a" and type another "a", or type some other letter then backspace it, "Anna" is replaced with "Anna".
[*:145j8knn]I had originally noticed it with "oh my g" being replaced with "oh moh my god" or something similar. After modifying the script, it no longer happens this way for "omg"->"oh my god". :?[*:145j8knn]This is especially problematic if I click into another window (like Firefox) and start typing then backspace what I typed, as it then deletes part of my text and types "Anna". This is partly a separate issue:
[*:145j8knn]Unlike AutoHotkey's hotstring recognizer, hotstrings() does not reset when you click, press arrow keys, home, end, etc. (Clicking and +home,delete are the main problems for me.)[/list]

[polyethene]

I committed an update which should have hopefully resolved the issues mentioned. Thanks for the bug reports.

[rjwilmsi]

I committed an update which should have hopefully resolved the issues mentioned. Thanks for the bug reports.

Thanks for the update - it is certainly an improvement. The "isn't" bug I had has now gone too. Also, the main bug I was suffering from was over extra firing of hotkeys, which I believe is the issue Lexikos mentioned.

However, one bug introduced by this update (I'm pretty sure) is that now backspacing of a hotstring doesn't work: e.g. type anna, get it converted to Anna by hotstrings("\bann(a|e)" , "Ann%$1%") rule, but then if backspace is pressed immediately, the character before Anna is deleted rather than the last 'a' in Anna. If the e = line is changed to remove BS this doesn't happen, but does that break other things? Thanks.

[polyethene]

Both bugs fixed in v2.53.

[Krogdor]

Thanks, this is great until we get fully implemented dynamic hotstrings!


Just a little modification I made in my own version of the function;

StringSplit, x, A_LoopField, `r
			If (RegExMatch(s, x1 . "$", $)) ; match
			{
				StringLen, l, $
				SendInput, {BS %l%}
				If (IsLabel([color=red]SubStr(x2, 1, -1)) && SubStr(x2,0) = ":"[/color])
					Gosub, [color=red]% SubStr(x2, 1, -1)[/color]
				Else
				{
					Transform, x0, Deref, %x2%
					Send, %x0%
				}
			}

Just makes it so you have to put a colon ( : ) after a label name if you want it to go to a label instead of replace the text; simply makes it a bit harder to accidentally go to a label instead of replacing the text...

Edit: Fixed with updated code.

[Lexikos]

Thanks Titan. [Edit]327%[/b] faster for removing, and 54% faster for replacing:

Else If a =
        t := RegExReplace(t, "\n\Q" . k . "\E\r.*?\n")
    Else If k !=
        t := RegExReplace(t, "\n\Q" . k . "\E\r.*?\n|$", "`n" RegExReplace(k,"\$","$$$$") "`r" RegExReplace(a,"\$","$$$$") "`n", _, 1)

Or maybe you just felt like rewriting it the long way.
End edit.]

Krogdor, it isn't possible for a label name to end with ":", therefore (IsLabel(x2) && SubStr(x2,0) = ":") will always evaluate to false. I suggest:

if (SubStr(x2,0)=":" && IsLabel(SubStr(x2,1,-1)))

[Krogdor]

Yeah, sorry about that Lexikos—I wasn't at the computer with my script so I was just going off of what I remembered. That would be the correct way to implement it.

[polyethene]

Just makes it so you have to put a colon ( : ) after a label name if you want it to go to a label instead of replace the text

I like the idea, but I'll keep it as it is now for the sake of compatibility.

I suppose you assumed avoiding RegExReplace would be more efficient, without having actually benchmarked it.

I had a tough time with the GC on Mono so I was actually concerned with the memory usage of:

To improve performance, the 100 most recently used regular expressions are kept cached in memory (in compiled form).

I haven't benchmarked this either so I can't be certain. Either way I should hope a parsing loop is more newb friendly which is a good enough reason to keep it.

[rjwilmsi]

Thanks to all for the continued work on this script. I have a bug with the latest version of the script to report. I believe Lexikos may have already mentioned this, but here goes:

hotstrings("(A|a)quir" , "%$1%cquir") ; acquire

using the above hotstring if 'aquir' is typed this is autoreplaced to 'acquir'. All correct so far, but if you then press backspace and 'r' another 'a' is added to the front of the word. This can be continued multiple times. I believe this is a problem for any hotstrings where the replace is longer than the find.

If the line with 'e = BS' is changed to remove 'BS' this goes away, but then this removes the fact that the function can work on user-corrected words.

[polyethene]

Thanks for the report. Fixed in v2.54.

[programmable]

This script works just fine for me, until I start using cut/paste.

hotstrings("(abcdefg)", "showHotstr")
Return

showHotstr:
msg := $1
MsgBox %msg%
Return

It works fine if i type

abcdefg

However, it fails if I cut/paste any part of the "abcdefg" string.

Any thoughts?

[MasterFocus]

Just to inform, the link is broken.
Hotstrings.ahk is currently located HERE.

[HotKeyIt]

Here is a small fix because some hotkeys are not being created, for example:

hotstrings("(\d\d?)\[color=Red];[/color](\d\d?)", "%$1%:%$2%")

If A_Index not between 33 and [color=Red]58[/color] ;should be 64 I think