If the idea of full-string masking is not desired, I will not spend time looking for the best spot within the loop to insert/test it. I don't know of any down-side to this approach and I think it comes with benefits. But there may be things that I have not considered up to this point?
Many issues can benefit from this, but with the way the code is it may be work. If you want to tackle this ConvertFuncs.ahk L154 is probably a good place to start
I personally don't see any issues either, and as Mike said there is suite of tests that will pick up any errors that do arise
that quoted strings are not being masked
They aren't, and you're right that it's causing issues, but with how I've interpreted this it may fix one issue but cause another. For example take this line
Code: Select all
Line := StrReplace(Line, "<>","!=")
It will replace all (non-comment) instances of "<>" with "!=" regardless of whether it should, masking would fix this
Then there's stuff that modifies the string, like L330 (replacing "" with `" in assignment), masking would
break this, unless it gets moved to the masking function
I'm also curious to whether masking will effect the param formats used in the convert folder (found at L3271) will be affected by masking?
But would that modular approach be a desired state by anyone involved with this project?
This would definitely improve maintainability
Please make a fork if you're interested in implementing some of these, with the way the projects set up we can add parts of your suggestions and test them against the test suite