testing 'or' as a variable name

[jeeswg]

Based on this post:
« What's on your mind? » - Page 213 - AutoHotkey Community
https://autohotkey.com/boards/viewtopic.php?f=17&t=52&p=303516#p303516

There are places here and there where AHK v1 could be improved re. error handling.
(Note: although considerations have to be made re. 'breaking changes'.)

Code: Select all

;AHK v1
;q:: ;test 'or' as a parameter
;note: 'or' is not allowed as a variable name in AHK v2
ol := "a"
ot := "b"
or := "c"
orr := "c"
ob := "d"
varname := "or"
MsgBox, % MyFunc(ol, ot, or, ob)
MsgBox, % MyFunc(ol, ot, %varname%, ob)
MsgBox, % MyFunc(ol, ot, 1 or 2, ob)
MsgBox, % MyFunc(ol, ot, orr, ob)
return

MyFunc(oParams*)
{
	local
	vOutput := ""
	for vKey, vValue in oParams
		vOutput .= vKey " " vValue "`r`n"
	return vOutput
}

Code: Select all

;AHK v2
;note: 'or' is not allowed as a variable name in AHK v2
ol := "a"
ot := "b"
;or := "c"
orr := "c"
ob := "d"
varname := "or"
%varname% := "c"
;MsgBox(MyFunc(ol, ot, or, ob))
MsgBox(MyFunc(ol, ot, %varname%, ob))
MsgBox(MyFunc(ol, ot, 1 or 2, ob))
MsgBox(MyFunc(ol, ot, orr, ob))

MyFunc(oParams*)
{
	local
	vOutput := ""
	for vKey, vValue in oParams
		vOutput .= vKey " " vValue "`r`n"
	return vOutput
}

[guest3456]

btw its the same for varname "and" also, and probably others

[jeeswg]

Reserved words for AHK v2 are listed here:
Concepts and Conventions | AutoHotkey v2
https://lexikos.github.io/v2/docs/Concepts.htm#names

Although not here, the AHK v1 situation is somewhat different:
Concepts and Conventions | AutoHotkey
https://www.autohotkey.com/docs/Concepts.htm#names

I feel for you with that very surprising, (no messages so) tough to debug error.
A good a-ha moment when you realised though, right?
Did you go with 'orr'? Cheers.

[guest3456]

I feel for you with that very surprising, (no messages so) tough to debug error.

no messages on AHK_L 1.1
however, if the param is ByRef, you DO get an error on AHK Basic 1.0:

Code: Select all

ol := "a"
ot := "b"
or := "c"
ob := "d"
MsgBox, % MyFunc(ol, ot, or, ob)
return

MyFunc(byref one, byref two, byref three, byref four)
{
}

when i saw that error i thought maybe i had some weird unicode encodings in my file, and tried to convert the file to ansi codepage and messed around with that for a bit

A good a-ha moment when you realised though, right?
Did you go with 'orr'? Cheers.

i went with 'orr' temporarily and then just went with 'offsetRight'

[jeeswg]

Ah, interesting!