Code: Select all
CurrentSizeTick := A_TickCount
LastSize := "", LastSizeTick = "" ; new line
Also, as I am running the script from a menu that ExitApps, how can I avoid inadvertently exiting the script when I reopen the menu?
Code: Select all
CurrentSizeTick := A_TickCount
LastSize := "", LastSizeTick = "" ; new line
It is assignment and allowed. Bad practice though.
Code: Select all
Url = http://download.adlice.com/RogueKiller/RogueKiller.exe
DownloadAs = RogueKiller.exe
Overwrite := True
UseProgressBar := True
DownloadFile(Url, DownloadAs, Overwrite, UseProgressBar)
;=================== Start Functions =====================================================================
DownloadFile(UrlToFile, SaveFileAs, Overwrite := True, UseProgressBar := True) {
;Check if the file already exists and if we must not overwrite it
If (!Overwrite && FileExist(SaveFileAs))
Return
;Check if the user wants a progressbar
If (UseProgressBar) {
;Initialize the WinHttpRequest Object
WebRequest := ComObjCreate("WinHttp.WinHttpRequest.5.1") ;Errors on Windows 7 if DefaultSecureProtocols has not been set
;Download the headers
WebRequest.Open("HEAD", UrlToFile)
WebRequest.Send()
;Store the header which holds the file size in a variable:
FinalSize := WebRequest.GetResponseHeader("Content-Length")
;Create the progressbar and the timer
Progress, H80, , Downloading..., %UrlToFile%
SetTimer, __UpdateProgressBar, 100
}
;Download the file
UrlDownloadToFile, %UrlToFile%, %SaveFileAs%
;Remove the timer and the progressbar because the download has finished
If (UseProgressBar) {
Progress, Off
SetTimer, __UpdateProgressBar, Off
}
Return
;The label that updates the progressbar
__UpdateProgressBar:
;Get the current filesize and tick
CurrentSize := FileOpen(SaveFileAs, "r").Length ;FileGetSize wouldn't return reliable results
CurrentSizeTick := A_TickCount
LastSize := "", LastSizeTick := "" ; new line
;Calculate the downloadspeed
Speed := Round((CurrentSize/1024-LastSize/1024)/((CurrentSizeTick-LastSizeTick)/1000)) . " Kb/s"
;Save the current filesize and tick for the next time
LastSizeTick := CurrentSizeTick
LastSize := FileOpen(SaveFileAs, "r").Length
;Calculate percent done
PercentDone := Round(CurrentSize/FinalSize*100)
;Update the ProgressBar
Progress, %PercentDone%, %PercentDone%`% Done, Downloading... (%Speed%), Downloading %SaveFileAs% (%PercentDone%`%)
Return
}
okSKAN wrote: ↑14 May 2021, 14:10It is assignment and allowed. Bad practice though.
https://www.autohotkey.com/docs/Variables.htm#comma
Users browsing this forum: peter_ahk and 136 guests