FileCopy Line Doesn't Work

[Bacon19331]

Hello, I made a post last night but I got frustrated and went to bed, I tried to change the variables up so it made more sense to the reader.. Basically I don't know why this file isn't copying to the remote location. I'll put in a screenshot of a MsgBox that looks perfect as the source file and the remote location. Please help me understand what I'm doing wrong.

Code: Select all

#SingleInstance force
FormatTime, time, , yyyy-MM-dd
name := time A_ComputerName
logdir = %A_AppData%\Microsoft\Teapot\

f::
FileCopy, "%logdir%%time%.txt", "C:\OM\%name%.txt"
; MsgBox, "%logdir%%time%.txt", "C:\OM\%name%.txt"
return

[Cuadrix]

It's not working because the command thinks that the quotes are a part of the path, which they are not.
You don't need quotes in autohotkey commands because everything is already treated as a string:

Code: Select all

FileCopy, %logdir%%time%.txt, C:\OM\%name%.txt

To write the above as an expression you would do it this way:

Code: Select all

FileCopy, % logdir time ".txt", % "C:\OM\" name ".txt"

[Bacon19331]

Ok, this worked. Thanks! But just wondering if a space was present in the source path, wouldn't you need quotes?

[Cuadrix]

Ok, this worked. Thanks! But just wondering if a space was present in the source path, wouldn't you need quotes?

You don't need quotes in commands at all, even if you have a space in your string
Quotes are needed around strings if the string is in an expression though e.g. % "C:\Program Files"

[Bacon19331]

Ok. Thanks for the help!

[boiler]

First thing I showed you in the thread yesterday was to remove the quotes. You then kept saying nothing was working and didn’t reply when I suggested that you show your updated code. So that was it.

[Bacon19331]

Sorry Boiler, it wasn't working for some reason, as I stated I tried to change the name of the variables but I must have screwed it up somehow.

[boiler]

No problem. Just was wondering if it was the quotes the whole time. That’s why it’s good to post your updated code even if you can’t see what could be wrong with it. Another set of eyes usually helps. We’ve all been there.