How to make my code work Topic is solved

[Mikaellpc]

I have some problems playing multiversus on pc because Down Normal Attack is very hard to do and I'm trying to make a script to make these actions easier, the purpose of my function is When aKey is pressed then do: ArrowDown Hold, key Hold, ArrowDown Release, Wait for aKey Release, key Release

But when i try to run my script i just get

image.png (13.61 KiB) Viewed 890 times

Down Attack can be a charged attack so i need to wait the aKey release

Code: Select all

#Requires AutoHotkey v2.0-beta

downCombo(key,aKey){
    if (GetKeyState(aKey)){
        Send "{Down down}"
        Send (key Down)
        Send "{Down up}" 
        while (GetKeyState(aKey)){
            sleep 20
        }
        Send (key Up)
    }
}

Loop{
    WinWaitActive "MultiVersus "
    downCombo("x","z")
    downCombo("c","v")
}

[boiler]

Code: Select all

        Send "{" key " down}"

Same for the other one.

[Mikaellpc]

Code: Select all

        Send "{" key " down}"

Same for the other one.

I have just one more question, can this if check with a loop I'm using cause performance problems or not?

final version if anyone wants

Code: Select all

#Requires AutoHotkey v2.0-beta

downCombo(key,aKey){
    if (GetKeyState(aKey)){
        ; Check if Down is already active
        if(GetKeyState("Down")){
            Send "{" key " down}"
        }
        else{
            Send "{Down down}"
            Send "{" key " down}"
            Send "{Down up}" 
        }
        while (GetKeyState(aKey)){
            sleep 20
        }
        Send "{" key " up}"
    }
}

Loop{
    WinWaitActive "MultiVersus "
    downCombo("x","z")
    downCombo("c","a")
}

[boiler]

I have just one more question, can this if check with a loop I'm using cause performance problems or not?

Check your CPU usage using Task Manager. If it's too high, add a Sleep in the loop or use SetTimer with a period that is sufficiently long to keep CPU usage low.